Coder Social home page Coder Social logo

Comments (3)

mbostock avatar mbostock commented on April 28, 2024

Hmm. Well, simulation.forces would need to return a copy, and make a defensive copy, of the map to prevent the map from being modified without force.initialize being called. And using simulation.forces to set new forces is potentially slower than simulation.force if it causes some of existing forces to be re-initialized… Also it exposes the fact that the simulation uses d3.map under the hood, which I’m not wild about.

A more conservative approach might be to just add a simulation.forces getter method which takes no arguments and returns an array of {key, value} objects representing the bound forces. It could be implemented as:

forces: function() {
  return forces.entries();
},

That seems like the most conservative approach as far as enabling inspection goes. The downside is that it’s not as easy to make bulk changes to the registered forces.

from d3-force.

nfcampos avatar nfcampos commented on April 28, 2024

@mbostock Thanks for the reply!
Yes, the getter like you described would be enough for my needs. My need for it comes down to the way I'm thinking about the props of the force layout component, ie.

<ForceLayout
  nodes={[...]}
  forces={{
    link: forceLink(...),
    center: forceCenter(...),
  }}
/>

and the component internally takes both nodes and forces and creates the simulation. (this is why I'd need the getter, to be able to know which of the forces passed in now are new.)
I'm however not sure whether it'd be better to just accept an already configured simulation object as a prop and avoid all this.

const sim = forceSimulation()
  .nodes([...])
  .force('link', forceLink())
  .force('center', forceCenter())

<ForceLayout
  simulation={sim}
/>

do you have any opinion either way?

from d3-force.

Fil avatar Fil commented on April 28, 2024

Closing due to inactivity. Note that another possibility is to create

function logger(simulation) {
  simulation.forces = new Map();
  simulation.addforce = simulation.force;
  simulation.force = (name, force) => (
    simulation.forces.set(name, force), simulation.addforce(name, force)
  );
  return simulation;
}

then call simulation = logger(d3.forceSimulation()) .force("x", …).force("collide", …)

simulation.forces will then hold the map of forces (see https://observablehq.com/d/d999cd71c09c86ef).

from d3-force.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.