Coder Social home page Coder Social logo

Comments (9)

mbostock avatar mbostock commented on May 2, 2024

Can you attach an example file I can use for testing purposes?

from d3-dsv.

robinhouston avatar robinhouston commented on May 2, 2024

Sure! GitHub won’t let me attach a .csv file, so I’ve zipped it.
Workbook1.csv.zip

from d3-dsv.

mbostock avatar mbostock commented on May 2, 2024

As TXT: Workbook1.txt

from d3-dsv.

mbostock avatar mbostock commented on May 2, 2024

Interestingly if you use FileReader.readAsText, it automatically strips the BOM bytes for you, per the Encoding specification.

from d3-dsv.

mbostock avatar mbostock commented on May 2, 2024

Seems like XMLHttpRequest and Fetch also automatically strip the BOM. Here’s a CORS-accessible URL I tested:

https://rawgit.com/mbostock/3fe6055309cff87cba4103837d914fee/raw/48cec3b15411fe2a9d9f678c5988d03b3988f498/test.csv

So my question is how are you getting a string with the BOM still in it? It seems like the BOM stripping should happen earlier, before it gets to d3-dsv.

from d3-dsv.

robinhouston avatar robinhouston commented on May 2, 2024

Sorry, I should have included a complete repro. I’m getting this in node, by fs.readFile(filename, "utf8", …). It looks as though the node developers have decided against stripping BOMs by default.

It’s okay if I should handle this in the app: I just thought I should flag it.

from d3-dsv.

mbostock avatar mbostock commented on May 2, 2024

Okay. I’m going to close this issue. If you want to submit a pull request with an edit to the README suggesting that Node users use strip-bom that would be 💯 .

from d3-dsv.

robinhouston avatar robinhouston commented on May 2, 2024

Great, will do!

from d3-dsv.

aubergene avatar aubergene commented on May 2, 2024

Gah this just got me too. Could we consider adding it directly to d3-dsv? I think the code is considerably shorter than the comment in the README, plus I wasted a good ten minutes, thanks Excel!

from d3-dsv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.