d-darwin / darwin-vue-ui Goto Github PK

First of all for the link click routing mixin. This helped me a lot 😊

Here a little feedback, to make it a little more robust.

https://github.com/d-darwin/darwin-vue-ui/blob/main/src/mixins/linkClickRouting.js#L49
This could be rewritten with:

// selects all <a> where href starts with "/"
// https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors#syntax
this.linksTags = this.$el.querySelectorAll('a[href^="/"]');

(if you want to be extra fancy you could even exclude the target blank with this selector this.$el.querySelectorAll('a[href^="/"]:not([target="_blank"])')

By doing this you will set possibly less event listeners and can omit the href check here