cxmeel / luau-gh-chart Goto Github PK

https://github.com/ClockworkSquirrel/luau-gh-chart/blob/6b6203e393ed3443254b7dc19770984df11f27fd/src/ParseChartData.lua#L101-L104

Sustain shouldn't be a boolean value; it should be a number which represents how long a player should sustain for.

https://github.com/ClockworkSquirrel/luau-gh-chart/blob/156f76b526f48906b1e0a7f1d3d2b48950d00d4f/src/ParseChartData.lua#L75-L79

Currently, the parser only looks for and supports a single BPM throughout the track. Although the .chart used in testing only has a single BPM throughout the track, some .chart files alternate BPM at different intervals, so the parser should be able to detect this and provide that information.

Example of a SyncTrack with BPM changes:

[SyncTrack]
{
  0 = TS 4
  0 = B 123257
  5376 = B 135000
  70656 = B 120000
}

Still not entirely sure what the "Time Signature" (TS) entries are for. AFAIK, TS is supposed to always be "4".