curioustechizen / android-ago Goto Github PK

Is this library available in other languages?
if not are you planning to add this feature in the near future

note: I can help translate into Arabic

Hello

why every time the calculations display "in 23 hours " what is the problem ?

Regards

HI and thanks for grate lib.
Using 'com.github.curioustechizen.android-ago:library:1.3.4' and XML looks like:

     <com.github.curioustechizen.ago.RelativeTimeTextView
                android:id="@+id/timestamp"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_marginEnd="2dp"
                android:layout_marginRight="2dp"
                tools:text="Just Now"/>

The time is always one hour behind. The device clock is set correctly.
I am in Sweden btw. What do you think? In Sweden we have summer time adjustment that mean during summer time is set forward one hour. It feels like your lib dont take that into consideration since the time I see on the Galaxy tab 3 is normal European time(correct time) (but it will for me in Sweden be one our behind)( We do this time thing to get more daylight sunlight)
https://www.timeanddate.com/time/change/sweden/malmo

I have also a Galaxy Note 4 running android 6.0.1 and time is correct all ok

Fatal Exception: java.lang.IndexOutOfBoundsException
Invalid index 1, size is 1
java.util.ArrayList.throwIndexOutOfBoundsException (ArrayList.java:251)
java.util.ArrayList.get (ArrayList.java:304)
android.widget.TextView.sendAfterTextChanged (TextView.java:7119)
android.widget.TextView.setText (TextView.java:3574)
android.widget.TextView.setText (TextView.java:3425)
android.widget.TextView.setText (TextView.java:3400)
com.github.curioustechizen.ago.RelativeTimeTextView.updateTextDisplay (RelativeTimeTextView.java:146)
com.github.curioustechizen.ago.RelativeTimeTextView.access$200 (RelativeTimeTextView.java:22)
com.github.curioustechizen.ago.RelativeTimeTextView$UpdateTimeRunnable.run (RelativeTimeTextView.java:265)

Seems to happen basically the moment a new item is added with timestamp = now, shortly after that, the value changes to "Just now" as expected

When a RelativeTimeTextView is included as part of a row item in a ListView or similar, the row item is recycled when the row goes off screen. When this happens, neither onVisibilityChanged() is called, nor onDetachedFromWindow(). As a result, the scheduled update of the display text continues according to the old value of reference time.

The correct behavior should be that when view recycling happens, the scheduled updates should happen according to the new value of reference time.

I have updated version from 1.3.3 to 1.4.0
then Just Now is not showing. Instead of that, it is showing 0 min. ago

I'm wanting to show ETAs that will commonly be less than 60 minutes but may occasionally be up to 120 minutes. In the case that the ETA is 60 minutes or less, the ETA text of my RelativeTextView updates every minute. In the case where an ETA is greater than 60 minutes, the ETA text updates every hour. However, I need the ETA to update every minute regardless of the difference between now and the reference time.

Current interval logic:

if (difference > DateUtils.WEEK_IN_MILLIS) {
   interval = DateUtils.WEEK_IN_MILLIS;
} else if (difference > DateUtils.DAY_IN_MILLIS) {
   interval = DateUtils.DAY_IN_MILLIS;
} else if (difference > DateUtils.HOUR_IN_MILLIS) {
   interval = DateUtils.HOUR_IN_MILLIS;
}

I think it would be helpful to add the ability to modify the time update interval. This could be achieved in a couple ways.
A) Add a public setter to set and override the time interval.
B) Allow subclasses to override the method that determines the interval.

I prefer option B as it provides more flexibility to the client.

@curioustechizen What are your thoughts on adding the ability to modify the time update interval?

add strings in pt

Introduce an abstraction for getting time (instead of using System.currentTimeMillis()) directly in RTTV.

Build on top of this to add automated tests, especially around scheduling the UpdateTimeTask.

Is there any way to remove the "ago" word from the RelativeTimeTextView?
To be more clear
for example if the RelativeTimeTextView is showing this String
"16 min. ago"
can I convert it to
"16 min."
this way is more user friendly ...you know shortest text is always better
thanks in advance

I think this library is causing some memory leaks - can you please fix?

I tested this with LeakCanary: https://github.com/square/leakcanary

And it keeps on detecting a memory leak here:

01-27 21:07:53.075 4217-4353/? D/LeakCanary: In com.example.simon.recyclerviewlistwithmongo:1.0:1.
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * com.example.simon.activities.PostDetailActivity has leaked:
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * GC ROOT android.view.ViewRootImpl$WindowInputEventReceiver.mMessageQueue
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * references android.os.MessageQueue.mMessages
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * references android.os.Message.callback
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * references com.github.curioustechizen.ago.RelativeTimeTextView$UpdateTimeRunnable.this$0
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * references com.github.curioustechizen.ago.RelativeTimeTextView.mContext
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * references android.support.v7.view.ContextThemeWrapper.mBase
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * leaks com.example.simon.activities.PostDetailActivity instance
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * Reference Key: f949ab86-5469-40cf-9f6b-bae54f1eedfa
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * Device: Genymotion generic Samsung Galaxy S2 - 4.1.1 - API 16 - 480x800 vbox86p
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * Android Version: 4.1.1 API: 16 LeakCanary: 1.3.1
01-27 21:07:53.075 4217-4353/? D/LeakCanary: * Durations: watch=5009ms, gc=116ms, heap dump=259ms, analysis=9831ms

Suggest fix: Please replace the context that is passed in RelativeTimeTextView.mContext with an ApplicationContext.

Thanks!

there is a Completed added to the time like Completed 5 hrs.ago how is that even possible and in another activity there is no problem

Prefix/suffix is not locale friendly, using a String format instead would solve that problem.

Am an Android newbie. please how do i add this to my project on android studio. I tried searching for the projects on Maven central but it was not there. Kindly add installation instructions to the readme.

Awesome plugin Btw.

The actual library says android:minSdkVersion="14" but the sample app has android:minSdkVersion="8".

Which is correct?

I'm trying to add Gradle build files and it won't compile without fixing this.

The method startTaskForPeriodicallyUpdatingRelativeTime() is called both in onAttachedToWindow() and in onVisibilityChanged(). This could result in the Runnable being scheduled twice.

This is because the first time the RelativeTimeTextView is added to its parent, both onAttachedToWindow() and onVisibilityChanged() are called (the latter is called for the parent Window).

How setText if I have String Date like "2015-08-02 01:01:50" ?

Description

Capitalization of the "Just Now" time text is inconsistent with the other English words and phrases used in this library.

Version

1.3.2

Severity

Minor

Steps to Reproduce

1. Set a time on the RelativeTimeTextView.
2. Observe the results as the time ages.

Actual behavior

The relative time text starts with "Just Now" and progresses to "1 min. ago", "Yesterday", "November 16", etc.

Expected behavior

The "Just Now" phrase is consistent with the other words/phrases used in this library. If the time text contains more than one word, I recommend capitalizing the first word and making the remaining words lowercase similar to today's "1 min. ago" format.

So "Just now" would become "Just now".

When I set mReferenceTime lower than currentTimeMillis method getRelativeTimeDisplayString returned "0 time ago"
For example: I have mReferenceTime = 10, and currentTimeMillis = 8. Method getRelativeTimeDisplayString will be return "0 time ago"

Any ideas?

It would be nice if it supported future reference times as well.

When text is displaying it is showing 21 hrs. ago instead of 21 hrs ago. Is there a way to get rid of " . "

If you have 1000 items in a recyclerview, running 1000 threads every time?
Or it detects when the item is not displayed and thus ends its thread of execution

In the stopTaskForPeriodicallyUpdatingRelativeTime() method, the mUpdateTimeTask is detached, resulting in the weak reference that connects it the the RelativeTimeView being cleared. In the startTaskForPeriodicallyUpdatingRelativeTime() method, the same mUpdateTimeTask is reused, but the weak reference is still null. As a consequence, the run() method in the runnable cannot update the text view.

It should be pretty easy to reproduce. Any action that results in the stopTaskForPeriodicallyUpdatingRelativeTime() method being called should cause the time to stop being updated. For example, minimize the app and restore it.

compile 'com.github.curioustechizen.android-ago:library:<LATEST_VERSION>'

I'm building an app that relies heavily on data binding. I was trying to include an instance of RelativeTimeTextView with XML bindings for app:relative_time_prefix and app:reference_time - however this results in a compilation-time error:

Error:java.lang.RuntimeException: Found data binding errors.
        ****/ data binding error ****msg:Cannot find the setter for attribute 'app:relative_time_prefix' with parameter type java.lang.String.

I'm not sure if what's causing this is the fact attributes/fields aren't set as @Bindable or Observable.., or that the property setters aren't named like the binding expects (if I understand the Data Binding documentation correctly).

Needless to say that when I remove the bindings of these fields from my XML, the compilation succeeds.

It would be awesome if somebody could add this support - and help make the library more future-proof :)

I'm using the following XML (irrelevant portions removed):

<data>
    <variable name="message" type="..."/>
</data>
....
<com.github.curioustechizen.ago.RelativeTimeTextView
    android:id="@+id/time_n_sender"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textSize="14sp"
    app:relative_time_prefix='@{"by " + message.senderName + ", "}'
    app:reference_time='@{message.timestamp}'
    tools:textColor="@color/gray"
    tools:text="by Mike, 30/02/2016 22:22:10"/>

P.S.
Does the format dd/MM/yyyy HH:mm:ss constitute a valid for app:reference_time?

It is an oversight that RTTV does not have a way to tell you what its current reference time is. Add a getReferenceTime() method.

Can I save the "setReferenceTime" even if the app destroys?

Add translations for the string resources (currently, there's just a single string - "Just Now"). We have English and German strings at present.

How to setText manually on RelativeTimeTextView

short suffix like facebook 1m, 18 Sep,

I want to change the Time's text to something like 5s, 5m instead of 5 seconds ago and 5 minutes ago.
I don't know where to change to custom text.

The reason i want to minimize is, it takes too much space when designing custom row layout.

Thanks,

Couldn't find where to change "hours ago" translation for multiple languages