ctsstc / coding-yabe-sei Goto Github PK

It might be good to separate required vs optional environment variables out in the env template as well as the configuration.js file.

There could be separate variables in the Configuration that get merged into one [use spread operator].

Just comment out sections for the env template.

Acceptance

• If the channel cannot be found handle the failure
  • Currently it throws a deprecation warning about not handling failed promises on client.channels.get.
• Convert config.json to config.js this will allow dynamic assignment such as env vars with defaulting.
• The boot message should use an environment variable to use to get the channel.
• Move server specific configurations into a centralized configuration.
• Utilize environment variables for server configuration.
• For now default to current values until later determined to change.
• Pull version from package.json into config.js

Breaking Changes

• Moved: botVersion, it is now defined in configuration.js which pulls from package.json
• Deletes: config.json in favor of config.js

For some of the mod commands it would be nice to have a decorated member that adds the following methods:

• isDev
• canManageGuild

This allows us to abstract some of the logic from the mod commands out into a separate class. This should result in a testable class, and more consistency across mod commands.

Get something implemented for giggles.

Acceptance

• Jest
• Travis CI

Migrations

• Travis CI will need to be added to the main repo: https://github.com/Academy-Of-Animu/Coding-Yabe-Sei

Post Merge Todos

• Add Circle CI Build Badge to README.md

I'm sure there's some npm package we can pull in as a dependency so we can remove these raw files from the repo's code base; they might as well be binary files. Plus an external dependency can update overtime with additional data too which is nice.

I would like to be able to set environment variables while developing via a .env file.

Acceptance

• Update node version to the latest lts.
  • Current LTS: v10.16.0
• Add nvmrc

When I am running non-production I would like to not be running dblapi.js