cshc / cshc-web

The 3rd version of the Cambridge South Hockey Club website

Cambridge South Hockey Club

This repository contains the source code for the Cambridge South Hockey Club website.

Full documentation (work-in-progress) can be found here: cshc.readthedocs.io

Migrating Database from Production to Local Env

1. On the EC2 instance:

mysqldump --skip-extended-insert --compact --default-character-set=utf8 cshc > dump_mysql.sql

2. Download the dump_mysql.sql file to your local machine.

3. Download the mysql2sqlite script from here

4. Run the script to create a new sqlite database file from the MySQL export:

./mysql2sqlite dump_mysql.sql | sqlite3 db.sqlite3

5. Replace the existing src/db.sqlite3 file with the one created in the previous step.

6. Copy the media files from production to the local dev environment. Note this also copies them to the (unused) staging bucket.

python manage.py media_copy --local

cshc-web's Issues

JSON contains a quote or escape sequence that was unable to be stripped

Happens in multiple pages where we pass the match report body in the window.props.

E.g. found in /matches/2625/edit/

Template error:
In template C:\cshcV3\cshc-web\src\cshc\templates\react\react_js.html, error at line 23
   JSON contains a quote or escape sequence that was unable to be stripped
   13 :     clubteam_detail: "{% url 'clubteam_detail' 'slug' %}",
   14 :     opposition_club_detail: "{% url 'opposition_club_detail' 'slug' %}",
   15 :     match_list: "{% url 'match_list' %}",
   16 :     about_committee: "{% url 'about_committee' %}",
   17 :     about_committee_season: "{% url 'about_committee_season' 'slug' %}",
   18 :     eos_award_winners: "{% url 'end_of_season_award_winners_list' %}",
   19 :   };
   20 :   
   21 :   window.CSHC_VERSION = '{{ VERSION }}';
   22 :   window.STATIC_URL = '{{ STATIC_URL }}';
   23 :   window.props =  {{ props|json }} ;
   24 :   window.gmapsApiKey = "{{ GMAPS_API_KEY }}";
   25 :   window.react_mount = document.getElementById('react-app');
   26 : </script>
   27 : {% render_bundle 'common' 'js' %}
   28 : {% render_bundle bundle_name 'js' %}


Traceback:

File "C:\cshcV3\cshc-web\src\core\templatetags\cshc_tags.py" in json
  164.         jsonlib.loads(clean)

File "c:\python36\Lib\json\__init__.py" in loads
  354.         return _default_decoder.decode(s)

File "c:\python36\Lib\json\decoder.py" in decode
  339.         obj, end = self.raw_decode(s, idx=_w(s, 0).end())

File "c:\python36\Lib\json\decoder.py" in raw_decode
  355.             obj, end = self.scan_once(s, idx)

During handling of the above exception (Expecting ',' delimiter: line 1 column 6050 (char 6049)),

Redirect HTTP traffic to HTTPS

"an apache virtualhost with a rewriterule"

Use React-Table on Venue List page

Add support for sorting by column and pagination

Add 'Clear All' to Venue List and Member List pages

Use Match List page as an example

Use collectfast instead of collectstatic for S3 files

Rather than always uploading every static file (~4000) every time collectstatic is called, this will speed things up a lot and only upload if the file has changed (based on an md5 sum comparison).

Ref: https://github.com/antonagestam/collectfast

Note: as per the README.md above, there's a fair bit of config to get right around caching etc.

Minify js and css static files

https://django-compressor.readthedocs.io/en/latest

Don't lose contact form data if submitted and not valid

Currently if you submit the Contact Us form and its missing a field the page is refreshed with error messages - but the form data is reset. This is a poor UX! Need to initialize the form data from the context in the Django template.

Also applies to Juniors contact form.

Add bulk-add training session page

• Access restricted to those with correct permission: training.add_trainingsession

• Copy form fields from https://www.cambridgesouthhockeyclub.co.uk/training/add/
• Copy view from TrainingSessionFormView
• Copy form from TrainingSessionForm

Mens and Ladies Vets and Indoor teams

Currently we just have a Mens Vets and a Mens Indoor team - and they're not described in the code or UI as particularly gender-specific.

Need to add a Ladies Vets and Ladies Indoor team and make the references to the Mens Vets and Indoor teams male-specific.

Better images for Match Details background image

Need to use:

• Men's playing image for Men's matches
• Ladies playing image for Ladies matches
• Indoor playing image for Indoor matches
• (Ideally) Mixed playing image for Mixed matches

Also:

• Smaller image for use on mobile view

Duplicate appearances can be selected on Match Edit page

To reproduce: click twice in quick succession on a player to add them to the list of appearances. This is possible because of the animation which means the component isn't removed immediately.

Need to disable the click action after the first click.

Optimize images using webpagetest.org

https://www.webpagetest.org - provides optimized images for download

Unicode strikethrough not displaying

https://www.cambridgesouthhockeyclub.co.uk/matches/2831/ uses unicode strikethrough in the Man-of-the-Match award but the strikethrough characters (U+0336) have been replaced with "?". They displayed correctly in the form input.

Venues List page filtering is broken

To reproduce: select a division from the Division Select filter. Venues are duplicated and the selected division is not displayed in the Select element.

Training Session bulk entry has daylight-savings/timezone bug

gzip js and css static files

Get memcached working on AWS Elastic Beanstalk app

Ref: https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/AWSHowTo.ElastiCache.html

Add recaptcha to contact forms

https://github.com/praekelt/django-recaptcha

Restrict max-width of Match Report and Blog images

e.g. '/matches/2625/'

Need some appropriate CSS (and probably a useful class name so we can make the CSS as generic as possible)

Add breadcrumbs to Change Password and Manage Emails pages

Should be Home > Profile > Change Password and Home > Profile > Manage Emails

Also, don't open these links in new tabs from the profile page.

Set up HTTPS on Elastic Beanstalk app

Refs:
https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/configuring-https-ssl.html
https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/configuring-https.html
https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/https-singleinstance-python.html

http://blog.lookfar.com/blog/2017/05/18/how-to-add-ssl-to-a-single-instance-ebs-server-for-a-node-js-app/

Add support for browser caching for S3 static files

e.g.

AWS_S3_OBJECT_PARAMETERS = {
    'CacheControl': 'max-age=86400',
}

Note: Ideally we'd add a version number as a URL parameter on the urls (of non-compressed only) static files (e.g. ?version={{ VERSION }}). However, sorl-thumbnail caching ignores the URL parameter so the thumbnail is not regenerated.

The sub-optimal solution for image files therefore is to rename them when they are changed.

Get Google Maps authentication working

E.g. error message on console from Member Profile page:

js?key=AIzaSyB78ntlJ3PL2D5rv8Rn14hNsqS7hTrU0p8:39 Google Maps API error: RefererNotAllowedMapError https://developers.google.com/maps/documentation/javascript/error-messages#referer-not-allowed-map-error
Your site URL to be authorized: http://cshc-web-prod.eu-west-1.elasticbeanstalk.com/accounts/profile/

https://console.developers.google.com/apis/credentials/key/191?project=cshc-website

Team Overview should use latest pic

Even though current_participation().team_photo returns a valid image url, the thumbnail is not being created/displayed.

Make Squad Roster table on Team Details page sortable

Use a React-Table implementation.

Show additional member details if authenticated user has correct permissions

If the authenticated user has the view_personal_data permission set...

• show member's address in the Google Map InfoWindow?
• show member's address and other personal details (emergency contact, medical etc) on their Member Details page?

Note: this info is visible on the Admin interface for anyone with permission to view members (e.g. captains, committee members etc). Maybe this should be restricted as well on the admin interface?

Override django-allauth templates

Need better templates for:

• /accounts/social/signup/
• /accounts/social/connections/
• /accounts/social/login/cancelled/

GDPR review

Ref: https://westaway.co/gdpr/

Need to provide contact info, explain what we use the info for etc.

Make sure T&Cs checkbox is linked on sign up form (add to Test Plan).

Add feature toggles for Playing and Umpiring Availability

Need to be able to hide these features entirely while they're in development.

Feature request: Centurions stats page

From Neil:

I see that the new Members’ Playing Records page allows you to sort players by total appearances - helpful for determining who qualifies for the Centurions’ Dinner. However, for the dinner I have a slight variance to the criteria, in that I only count regulation outdoor matches - indoor games, being shorter time and not comparable, are excluded. Could we add a Centurions’ page to the stats section, showing players by outdoor appearances (with a note to explain that only appearances in full-length outdoor fixtures, as at the end of each season, are counted), and maybe also everyone who’s reached 75 caps - potentially within a season of qualifying. If you wanted to be clever, the list could exclude anyone who’s reached 75 appearances but whose status is not ‘current’.