csga5000 / tinymce-prevent-delete Goto Github PK

also
return [8, 9, 13, 46].contains(c)
code, throws exception for me (i am using more plugins)

Thanks for this plugin! Save me time in my project.

I noticed a bug. Say I have a paragraph and inside the paragraph, I have a mceNonEditable span at the end. With the current code, if you put the cursor at the very end fo the paragraph, it won't let you press enter to start a new paragraph, even though this wouldn't affect the span.

I believe this is caused by this.check code. It calls this.checkChildren to see if any children have mceNonEditable. The problem is, this is reversed logic. It makes the p element return as mceNonEditable just because it has an inline span that is mceNonEditable as a child.

TinyMCE doesn't support nesting editable components so at whatever element you set mceNonEditable on, all children are non-editable. The code should therefore check parents, that way if say a element was inside the it would still prevent a delete.

First of all, thank you very much to publish this plugin so we all can use it. I would like to know, in a scale from 1 to 10, how stable do you think this plugin is today for production use?

thanks :-)
Fernando