cschol / vcv-plugindownloader Goto Github PK

Cloning github repo led to a (small) naming error in the directory (vcv-plugindowloader instead of vcv-plugindownloader).
Also : didn't have permission to execute the program, so had to execute a sudo chmod +x vcv-plugindownloader.py first

Just to make sure, when you refer to running the script in the plugins directory, you mean the plugins directory that resides under the github>rack dir ?
Not to be confused with the Documents>Rack directory (for the non-dev version).
(which normally contains all plug binaries)

Hi, thanks for the script!

I noticed mscHack falls foul of the "checkout latest tag" logic, because the script tries to build 4.x which fails, whereas just building the master branch succeeds (against Rack v0.5.1 tag.)

So I'd suggest applying:

 PLUGIN_COMMITTISH_MAP = {
-    "Fundamental": "v0.5.1"
+    "Fundamental": "v0.5.1",
+    "mscHack": "master"
 }

to correct this.

You might also like to consider running git submodule update --init --recursive immediately prior to make since this fixes the build for one other plugin (can't remember which one right now) and is harmless and free if no submodules exist. It throws the AepelzensParasites plugin, but that fails anyway because it needs a specific git submodule command as per its README.

The title says it all basically : a subdir containing either weblinks to repo's that have no binaries
Alternatively : log/textfile containg the URL's

BTW : looks great so far !!!