csalmeida / protonmail-themes Goto Github PK

This is ProtonMail 4.0.0-beta7 with custom theme Green Lume:

When I got the theme last week I recall there being light and "full" / dark versions. (Did you remove / consolidate them?) Anyway, I tested the full/dark versions of both Green Lume and Vitamin C with the above result in the plain text composition box and in the address fields.

It's possible there are other buggy bits but this is all I've noticed so far. I use the Firefox add-on Dark Background and Light Text atop the theme(s) to brute-force said areas back into normal readability.

See: https://choosealicense.com/no-permission

Hi-just a copy of what I wrote on Reddit - but the ProtonMail CSS you've developed is great.

Best would be a short menu that just labelled some key variables e.g. Top Banner, Side Verticle Banner Menu Fonts etc.. You could set each variable as a "theme", and then refer to it throughout the CSS. That way all the user has to do is put in whatever color they want in each variable, and it then propagates. That is what I have done in effect - but more by just seeing how you used certain colors, and searching and replacing all refs. to that color (all obviously in hex code). It is a crude way to do it, but it works.

Sorry best I can do as I have a job and family that require focus. Thanks for the help.

Maybe some dark grey shade with white text in the active writing pane (or at least a way to clearly change it) vs. white. Again if you just labelled clearly what some theme color choices are in a header section, for different elements - the user can then just tweak the hex code easily. Have done this with other CSS sheets. So at the top, the user just makes a few simple choices, and then as all the CSS instructions are relative, it would propagate easily.

I'm wondering if the padlock colour can be adjusted depending on how the message is encrypted.

In the default theme, PM's emails and internal emails from other users get the purple padlock, PGP encrypted messages from external providers used to get a green padlock but seems like it doesn't do that on v4 and unencrypted messages gets solid black. In the custom themes, all the messages get the same padlock colour.
See a few screen shots comparing the custom theme and default theme

Hello,

I absolutely love this theme but sadly it's no longer working with the ProtonMail V4 rollout.

Are there any plans to port it over for use with stylus to work with V4 or at least something very similar available?

Cheers.

These themes kind of seem useless without addressing the main issue.
Is it not possible to change the bulk of the window?

First, thank you for making these & your time.

You've may have noticed but the top nav bar no longer changes to black with the recent updates — it stays the default color. Can this still be overridden?

Thanks again!

I've noticed that an npm package as been flagged as a security vulnerability. This poses no problems for anyone using the themes as they're pure .css.

This is a difficult error to fix as documented in the node-sass repo, but it is worth flagging.

                    === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Arbitrary File Overwrite                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ tar                                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.4.2                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ gulp-sass [dev]                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ gulp-sass > node-sass > node-gyp > tar                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/803                             │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 high severity vulnerability in 6938 scanned packages
  1 vulnerability requires manual review. See the full report for details.

Could you do a v4 theme that looks like the deprecated Inbox by Gmail?

You can see one made for the older Protonmail version here.

Themes on version v4.0.0 have a white background on the settings panel .subnav. This can be replicated by clicking Settings and Appearance whilst logged into a PM account.

At a glance it looks like adding the following block to templates/@theme-base/_full.scss:

// Settings subnav
.subnav {
 background: lighten($base, 5%);
}

It currently looks like this (using the Dark Bubble Gum theme):

On the early stages of this project I've had a request from a user about a theme that is accessible to people with deuteranopia and attempted to create a theme that makes ProtonMail accessible to these users.

This theme now requires fixes in order to be compatible with version v3.15.30.

Issue:

Color scheme is not applied to the entire layout.

Steps to replicate:

1. Apply theme attached to this issue.
   deutera_one_v1.txt

This issue was brought to my attention by the same user who requested the theme a couple years ago.

I'm on Firefox and I'm using Stylus. I pasted the CSS. But, this is what it looks like:

Is there something I'm doing wrong? Is the theme no longer compatible?
Thanks in advance.

EDIT: it works on the beta version of ProtonMail. Sorry for the trouble 😅

I'm not sure if you already want issues for the v4 versions, but I'll post this anyway ;)

Everything looks perfect in Column layout (the email preview-pane), but in Row layout the unread emails seem to have a white background.

Keep up the good work! It's much appreciated 👍

Noticed while using the v4 gruvbox_full theme.

I imagine this is also a problem for any other themes using light-colored text. The composition box is white and the text inside of it remains light.

Since PM's dark mode seems to now take care of just about everything but HTML rendered emails, have you looked into updating your full modes to support their methodology?

I have been looking around the code to see if I missed something about how to turn on dark mode but I came up short. The preview shows that a dark mode is available for some themes. In my case, the theme in question is Dracula. I believe there is a class or something missing in the scss however, I am not too familiar with scss/css because I don't use it often. The case may be that I am overlooking something.

Hello,

I'm trying to use the "nord full" theme but not having any luck.

I followed your instructions:

-Installed "stylus" extension for Firefox
-Wrote a new style by copy and pasting your entire "raw" code
-Enabled it for "URLs on the domain" for both "beta.protonmail.com" and "mail.protonmail.com"
-When logged into ProtonMail the "stylus" icon next to the browser URL bar shows a "1" indicating that the style should be enabled
-When logged into ProtonMail "settings>appearance>custom themes" box is completely empty

Nothing has changed.

ProtonMail version prior to logging in indicates "v3.16.51"

Thanks in advance.