Heroku Deployment fails, gmp needed about heroku-buildpack-crystal

[beanieboi]

@bcardiff i worked on a couple of buildpacks before, i will try to add gmp to the buildpack, to remove this restriction.

[bcardiff]

libgmp is there since 0.16 at least.
using "big" of the std requires gmp which is not installed by default.
related crystal-lang/homebrew-crystal#15 (comment)

Are you using big_* explicitly in your code?

We might need to work something similar to https://github.com/begriffs/heroku-buildpack-ghc to get gmp installed by default in heroku just in case :-(

Or finding/building a buildpack to install gmp, but I am not sure that will work.

[beanieboi]

i added sidekiq as a dependency and sidekiq uses big_float (https://github.com/mperham/sidekiq.cr/blob/master/src/sidekiq/core_ext.cr#L1). this means no Sidekiq on Heroku :(

[beanieboi]

@mperham do you think you can remove the patch, it looks like this got fixed in a newer version of crystal.

[mperham]

Yep, this was needed pre-0.18 but no more, removed from master.

[beanieboi]

@mperham thanks so much!

[bcardiff]

Isn't it nice when the "fix" is to delete code? :-)

Let's leave this open until gmp or other runtime dependencies are added in the buildpack.

[bacongobbler]

@beanieboi if you can write a fixture + unit test that covers this problem after #12 is merged, it should be easy to confirm the fix works.

[beanieboi]

@bacongobbler sure, will look into it.