Port config from ENV about heroku-buildpack-crystal

[zamith]

The port should be coming from ENV, I believe. Is it not working for you?

[bcardiff]

@arr-dev you can set the port in your program as

port = ENV["PORT"]?.try(&.to_i) || 8080

And it will work in heroku but then, instead of using a command line option you will need to set the environment variable. Totally viable, but I like more the command line option alternative.

[zamith]

@arr-dev Does that answer your question? Can we close this?

[arr-dev]

That wasn't clear by looking at the docs, but yes, sure, can be closed.

[zamith]

@bcardiff Maybe we can add something on the README in this regard. What do you think?

[bcardiff]

@zamith Yeap, I agree. A short section with port/binding description options and read more in the post it should be enough. Otherwise the people that reach this repo has no clue how to use it.

[zamith]

@arr-dev Do you want to take a stab at it?

[arr-dev]

@zamith Sure, I'll give it a go.

[zamith]

Awesome. Thanks a lot.

[arr-dev]

Tried to formulate it in #7, but when I thought about it,
I wanted to change linked blog post more than the README,
since that was the actual cause of my confusion.

Can I ask what's the rationale in setting port from CLI instead of using ENV["PORT"]?
It seems much easier for apps to just read ENV.

[bcardiff]

1. I think it is more common to pass options in CLI than in ENV.
2. The --port $PORT was already there :-)
3. Rails and other programs that starts an http server use --port

I know that crystal foo.cr -- --port 9090 might be confusing but usually the default port should be fine in development. When foo is compiled, ./foo --port 9090 looks better that PORT=9090 ./foo IMO.

This whole story might get simplified if a Procfile is supported/generated for dynos and the processes for each role will need to be declared.

[arr-dev]

Thanks for the elaborate response :-)
Cheers