cryostatio / cryostat-grafana-dashboard Goto Github PK

• Tag release (https://github.com/cryostatio/cryostat-grafana-dashboard/releases/tag/v2.0.0)
• Build in Quay (quay.io/cryostat/cryostat-grafana-dashboard:2.0.0)

https://grafana.com/grafana/plugins/grafana-simple-json-datasource/

https://grafana.com/grafana/plugins/grafana-simple-json-datasource/

We currently use this plugin to link the jfr-datasource and Grafana dashboards together. This datasource plugin is no longer maintained and we need to build it separately, include it overlaid on top of the Grafana container image, and set an environment variable to get the dashboard to register the plugin. There are alternate plugins that could possibly be used instead, or else there seems to be a way to build the required functionality into the jfr-datasource itself.

• #26
• cryostatio/jfr-datasource#174

The Grafana Dashboard has't been updated and needs redesigning to support new events. Here are some of the things to look into:

• Categorize panels according to events. This will be easier for extension.
• Fix unit display.
• Larger default time frame.
• Rename dashboard to Cryostat or probably the recording name #2
• Clean up unused fields (i.e. hashKey generated by Grafana)
• Support separate dashboard with filters for jdk.ObjectAllocationSample
• Each "sub" dashboard should have direct link back to the Main Dashboard.
• Dashboard should default to open main Cryostat Dashboard on launch.

Datasource task:

• cryostatio/jfr-datasource#128
• cryostatio/jfr-datasource#62
• cryostatio/jfr-datasource#129
• cryostatio/jfr-datasource#130
• cryostatio/jfr-datasource#78
• cryostatio/jfr-datasource#134

The env var GF_INSTALL_PLUGINS=grafana-simple-json-datasource is not set and the grafana.ini does not properly list the plugin location within the container image, which leads to the Grafana container not registering the plugin and not being able to communicate with the jfr-datasource container.

This script is for developer use. Let's remove the GRAFANA_TAG and only tag builds as latest.

          Looks good!

One RFE for later, this tags releases with the v prefix intact. It would be nice to strip this from the tag name when tagging the container image (e.g. v2.4.0 -> 2.4.0) to be consistent with other components.

Originally posted by @ebaron in #38 (review)

See also #19 - maybe this is a duplicate of that?

Currently the pre-provisioned dashboard is named, well, Dashboard. Should this be ex. Cryostat instead?

The newest 7.x release at this time is 7.5.15.

When testing Pod Security Admission changes in the operator, I noticed the following error in Minikube:

Warning  Failed     35m (x4 over 35m)    kubelet            Error: container has runAsNonRoot and image has non-numeric user (grafana), cannot verify user is non-root (pod: "cryostat-sample-557bc597-xjwkj_cryostat-operator-system(c11fabdc-aaf8-4f16-b3e5-ed9c534666eb)", container: cryostat-sample-grafana)

As suggested by @cmah88, we should have some helper texts to explain:

• How to zoom in and out within a graph.
• How to manually pick time frame.
• How to enable auto refresh.
• Each panel/category should briefly explain what it represents.
• Add some notes on the links to separate dashboard for jdk.ObjectAllocationSample event.

This would greatly improve user experience as it reduces the amount of steps to see the data points.

Waiting on grafana/grafana#6288.

For now, we need to investigate which time frame is best (currently now-24h <-> now) based on use cases.

Suggested by @cmah88 :D

See cryostatio/cryostat-core#168 . Something similar should be done here.

See also dependabot/dependabot-core#6067

Using a GitHub workflow instead of the Quay build automation would give us some more flexibility over how the images are tagged. Ideally our development versions could be tagged 'X.Y.Z-dev/snapshot', to bring them in line with other Cryostat images. After reading this issue actions/runner-images#1445, I'm unsure whether this would help or hurt the issue of DockerHub rate limiting.