Coder Social home page Coder Social logo

Comments (4)

jtbandes avatar jtbandes commented on July 19, 2024 1

Can't imagine that it would have to do with line endings, since the Reader is also using stat 😫

this._size = stat.size;

from rosbag.js.

janpaul123 avatar janpaul123 commented on July 19, 2024 1

@jtbandes Yeah but on windows non-binary files are typically converted by git during clone/checkout to windows format which uses two bytes for line endings (cr-lf) instead of one on unix systems (lf). So it would make sense for stat.size to also report 22 bytes.

from rosbag.js.

janpaul123 avatar janpaul123 commented on July 19, 2024

Omg, classic windows. assert.equal(reader.size(), fs.statSync(fixture).size); seems reasonable to me.

from rosbag.js.

gkjohnson avatar gkjohnson commented on July 19, 2024

Heh, I was screaming on the inside, too.

assert.equal(reader.size(), fs.statSync(fixture).size); seems reasonable to me.

Great -- tacked this onto PR #30

from rosbag.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.