crowdstrike / fdr Goto Github PK

Would be nice to be able to ingest AWS CloudTrail logs if we have Cloud Security setup for AWS.
If we do not have this, we have to setup CloudTrail twice (once for IoA, once for ourselves).

The aws sts assumed role has a max duration of 1 hour - the assumed role should be refreshed on expiration

https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html

Currently if you set DO_OCSF_CONVERSION to true and no mapping files are provided the script will consume events like normal without doing conversions.

I'd prefer it to error when no mapping files are found.

Possible error message:

No mapping files found in './ocsf/mappings'. Please provide mapping files or set 'DO_OCSF_CONVERSION' to false.

The ocsf.py file implements a non-standard mapping rule definition. Since Crowdstrike is a contributor to OCSF, and the YAML-based approach is way better than using JSON to define mapping rules to translate to OCSF, it would be a good opportunity to standardize this format to be used to translate anything to OCSF, not just FDR.

See this discussion for details.