crocodilertc / crocodile-rtc Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 9.0 940 KB

Simplified web-based real-time communications built around WebRTC, SIP, MSRP, and XMPP

License: MIT License

JavaScript 91.12% CSS 8.88%

crocodile-rtc's People

Stargazers

Watchers

Forkers

jfend sa4250mnpo70 mykook zcasthd tymiles003 mibamur garyfub sewakram jatsmulator

crocodile-rtc's Issues

Add support for reINVITEs

Currently neither JsSIP nor the SDK support reINVITEs. This prevents media renegotiation (changing media streams, hold/resume), and causes difficulty with supporting session timer.

Improve behaviour when errors are encountered during connection/authentication

Should not retry connection for authentication failures (hub REST calls or websockets)
Limit the number of connection attempts - don't let it go on forever

While here we should consider renaming connect/disconnect to start/stop, to make it more obvious that the SDK handles retries.

XMPP: don't "lock on" to a full JID when receiving delivery receipts

Should continue to use the bare JID until a proper user response is received. Locking on to composing notifications is probably less bad than delivery receipts, but better to only lock on when receiving a real message.

Extend MediaSession API to support DTMF

Add API to allow sending and receiving of DTMF tones. Default to using the WebRTC API, which should use telephone-event RTP packets as per RFC 4733, but allow the application to choose to use SIP INFO messages if desired (send via the JsSIP DTMF API).

XMPP: sending two presence stanzas on startup

One is an empty presence, the other has a tag in it. Jitsi ends up spamming availability messages in it's chat window thanks to this.

Perform better translation of XHTML to plain text for XMPP

When sending XHTML over XMPP, we also send a plain text version of the message in the <body> tags. Currently the plain text is just the XHTML with the tags stripped out; it would be better to apply some basic formatting to make the two versions more similar. For instance:

Replace <p> and <br/> with appropriate line breaks.
Turn <ul> into bullet points using "*" or "-".
Turn <ol> into a numbered list.

How useful this enhancement is depends on how likely we are to see XMPP clients that don't support XHTML-IM (XEP-0071).

XMPP onData event being fired when send messages fail

SDK fires onData event as if data has been received when it is actually an error response.

Receiving a roster push removing an unknown contact fires onNewContact event

Seen a couple of occasions where a deleted contact is immediately added again. I believe this is generally due to attempting to remove a contact twice. This ends up with the server sending two roster pushes removing the contact - the second push incorrectly triggers the onNewContact event.

blob.slice is undefined for Safari webkit

While testing MSRP data sessions between Safari and Chrome, I was getting an error sending from Safari to Chrome. This was the error from Safari:

TypeError: 'undefined' is not a function (evaluating 'this.blob.slice(this.sentBytes, end)') crocodile-rtc.js:22848

So I logged out this.blob on line 22848 and found out that Safari is looking for blob.webkitSlice instead of blob.slice.

I fixed it with this code:

if(typeof this.blob.slice === 'function') {
    chunk.body = this.blob.slice(this.sentBytes, end);
}else if(typeof this.blob.webkitSlice === 'function'){
    chunk.body = this.blob.webkitSlice(this.sentBytes, end);
}

Make intelligent selection of default data transport

If the data transport is not explicitly selected by the application, we need to automatically select the most appropriate one, based on the data being sent. Currently we just default to page mode.

Some of the variables we might want to consider:

Binary vs text
Size of data to send
Whether XMPP/MSRP are configured/started

Check for available media sources using MediaStreamTrack.getSources()

At startup, we currently attempt to check media source availability by requesting access using getUserMedia, then immediately closing the stream again afterwards. This can be replaced with code that checks the output of MediaStreamTrack.getSources() (previously getSourceInfos), which is available in Chrome 30+.

Calling presence.getContacts() loses presence information for extended periods

Found following discussion with @jfend.

My testing has shown that the XMPP server only automatically sends presence information the first time you request the full roster. This means that calling getContacts later will lose the presence information for an extended period of time - probably the next time that contact changes their presence, unless we provide a way of requesting a refresh. Rather than flooding the network with presence requests, I plan to change the code to transfer any presence information from the old contact list to the new one.

Remove jQuery dependency

Though client applications are likely to use it, the library has very little dependency on jQuery, and thus it would be better to remove the dependency and give the application more freedom to choose something else.

I think our use of jQuery is limited to a few jQuery.extend and jQuery.ajax calls. The extend could be replaced with a function in Util, and the ajax calls could be done directly with XmlHttpRequest.

Add support for session timer

We want the client to be handling session timer refreshes, rather than the network. Also depends on issue #4.

crocodilertc / crocodile-rtc Goto Github PK

crocodile-rtc's People

Stargazers

Watchers

Forkers

crocodile-rtc's Issues

Recommend Projects

Recommend Topics

Recommend Org