criteo / android-publisher-sdk-google-adapters

Criteo Adapters for Google Mediation (Android)

Criteo Adapters for Google Mediation (Android)

This repository contains Criteo’s Adapter for Admob Mediation. It must be used in conjunction with the Criteo Publisher SDK. For requirements, intructions, and other info, see Integrating Criteo with Admob Mediation.

Download

Add the following maven repository into your top-level build.gradle file:

allprojects {
    repositories {
        mavenCentral()
    }
}

Then, in your app's module build.gradle file, add the following implementation configuration to the dependencies section:

implementation 'com.criteo.mediation.google:criteo-adapter:6.0.0.0'

License

Apache 2.0 License

android-publisher-sdk-google-adapters's Issues

Should not be treated as noFillError() when Criteo is initialized for the very first time in CriteoAdapter

https://github.com/criteo/android-publisher-sdk-google-adapters/blob/0a8d2f5ab8499c7fe7854b9049847ea8b79211bc/mediation/src/main/java/com/criteo/mediation/google/CriteoAdapter.kt#L188,L197

In case of not initialized in CriteoAdapter#initialize with param tagForChildDirectedTreatment, it will call Criteo.Builder().init(). When it's initialized successfully here then it should return true to continue loading the ads, otherwise it will always fail for the first time.
Not sure if I misunderstand this piece of code, or is there any thing to prevent from doing that way?