crissdev / knockout.mapping Goto Github PK

Some tests fail when using Knockout 3.x

Knockout 3.3.0 was released. A spec runner for this version must be added.

Although the library requires Knockout it doesn't export the mapping property in ko namespace. Apart from that, a check for ko availability should be implemented.

Hi crissdev,

Here is an example about the case.

It will js.b.format() is not a function error.

I am using a js library called Moment.js, and .format() is a method within the "proto" (using Chrome devtool).

Thanks,
Kyle

For this purpose gh-pages branch was created.

Highlights

• clone official documentation but present it in a structured and more detailed form. Links to source code should also be provided. Permission from Knockout team is required due to content duplication.
• provide a quick start or some short tutorials.
• provide interractive examples
• and many more...

Try to merge valid PRs from upstream repository and fix issues.

• Fix SteveSanderson#124 - Use hasOwnProperty to check for bucket existence 1cf041d (PR SteveSanderson#173)
• Put null check first in canHaveProperties 57a0b56 (PR SteveSanderson#149)
• Use intermediate vars to decrease minified size f97d5cd (PR SteveSanderson#151)
• Only get types once in mergeArrays e6c5631 (PR SteveSanderson#148)
• Incorrect handling of properties with periods (SteveSanderson#96)
• allow JSON.stringify parameters to be specified to ko.mapping.toJSON 8e55292 (SteveSanderson#205)
• include option is not working properly (SteveSanderson#176) - to verify
• Mapping doesn't work when properties listed in different order (SteveSanderson#203)

Hey guys, I noticed some issues in a few applications of mine, when users were using IE-8.

If I try to do a ko.mapping.toJS of an object that contains an observable property of a date, it would result in a {} empty object.

Fiddle: https://jsfiddle.net/gqsekzvp/3/

You cant actually run a fiddle on IE-8, I had to paste that in my own application. I will try to find out the issue, but if you guys have any idea, let me know.

I tried with Steves version as well, so this is possibly an old bug.

Once version 2.5 is released the npm package should be published.