Comments (4)
Hey there, thanks for the report!
I'll apply the necessary changes and release a new version of the lib.
from email-forward-parser.
Ok so I understand the setting re2
as a peer dependency here as well would definitely fix the issue, however I don't plan to do so.
By reading the npm docs, I see that the behavior of peer dependencies is different across npm versions:
npm versions 1, 2, and 7 will automatically install peerDependencies if they are not explicitly depended upon higher in the dependency tree. For npm versions 3 through 6, you will receive a warning that the peerDependency is not installed instead.
This is quite an issue as I don't want to force host projects using this library to set re2
as a dependency. Peer dependencies were introduced to answer the use-case of plugins (https://nodejs.org/es/blog/npm/peer-dependencies/#the-problem-plugins), which is not the scope here in my opinion.
Furthermore, I see that the url-regex-safe
lib has been updated and that it fixes your issue.
So I think it's safe to close this issue. Feel free to re-open the issue if needed.
from email-forward-parser.
Indeed, you are right, our case was fixed but having two or more dependencies using node-re2 could be likely at some point, and it would hinder the usage of either library.
Probably then node-re2 has to fix this, i saw in that issue that the author was removing global state, which is highly probable the cause of this.
from email-forward-parser.
Agreed, but yes in any case it's the responsibility of node-re2
to fix the underlying issue.
from email-forward-parser.
Related Issues (8)
- Python version? HOT 1
- Outlook Desktop does not parse the forwarded email HOT 11
- Would it be possible to get the layered forwarded emails? HOT 3
- Add types for the library HOT 1
- error while importing package HOT 5
- Running this package with node18 in aws lambda results in GCLIB errors HOT 2
- Improve coverage of IONOS by 1 & 1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from email-forward-parser.