Coder Social home page Coder Social logo

Comments (4)

eliottvincent avatar eliottvincent commented on June 23, 2024

Hey there, thanks for the report!
I'll apply the necessary changes and release a new version of the lib.

from email-forward-parser.

eliottvincent avatar eliottvincent commented on June 23, 2024

Ok so I understand the setting re2 as a peer dependency here as well would definitely fix the issue, however I don't plan to do so.
By reading the npm docs, I see that the behavior of peer dependencies is different across npm versions:

npm versions 1, 2, and 7 will automatically install peerDependencies if they are not explicitly depended upon higher in the dependency tree. For npm versions 3 through 6, you will receive a warning that the peerDependency is not installed instead.

This is quite an issue as I don't want to force host projects using this library to set re2 as a dependency. Peer dependencies were introduced to answer the use-case of plugins (https://nodejs.org/es/blog/npm/peer-dependencies/#the-problem-plugins), which is not the scope here in my opinion.

Furthermore, I see that the url-regex-safe lib has been updated and that it fixes your issue.
So I think it's safe to close this issue. Feel free to re-open the issue if needed.

from email-forward-parser.

katlim-br avatar katlim-br commented on June 23, 2024

Indeed, you are right, our case was fixed but having two or more dependencies using node-re2 could be likely at some point, and it would hinder the usage of either library.

Probably then node-re2 has to fix this, i saw in that issue that the author was removing global state, which is highly probable the cause of this.

from email-forward-parser.

eliottvincent avatar eliottvincent commented on June 23, 2024

Agreed, but yes in any case it's the responsibility of node-re2 to fix the underlying issue.

from email-forward-parser.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.