cradlepoint / jsonapiary Goto Github PK

Unfortunately under Windows I have the different line endings \r\n instead of \n. As long as the tests directly compare against Strings this causes issue.

Not sure what the cleanest approach is. Simplest would be to replace all \r\n with \n.

Seems that only List is supported as of now but could be probably replaced with Collection instead:

https://github.com/cradlepoint/JsonAPIary/blob/master/src/main/java/com/cradlepoint/jsonapiary/serializers/JsonApiSerializer.java#L310-L329

Unfortunately I can't build and verify it under Windows (#13)

Hey, me again. I discovered some behavior I think it is worth to discuss.

We have the following use case:

think of an customer API endpoint to create customers. E.g.
POST api/customers

where a list of customers can be given in as body, e.g.:
{
"data": [
{
"type": "customer",
"attributes": {
"name": "Best Customer",
"age": 40,
"someother": "value"
}
},
{
"type": "customer",
"attributes": {
"name": "Best Customer2",
"age": 80,
"someother": "cool!"
}
}
]
}

Note: There is no ID in one of these objects because they need to be created.

Now the behavior is, that after JsonApiAiry with Jackson deserializes the JSON shown above to an Java List with 2 identical objects. The ID of both is, as expected, null, but the attributes are equal, and the attributes section of the second new customer gets ignored/forgotten.

Why is that so?

@JsonUnwrapped is a Jackson annotation that "flattens" the attributes of an inner variable and puts all key/values into the current level of the json body.

The @JsonUnwrapped payload is not taken into account by JsonApiary. I tested and debugged around. The ObjectMapper treats it correctly (even with Jsonapiary module loaded) if not wrapped in a JsonApiEnvelope. But as soon as an object gets wrapped in JsonApiEnvelop the unwrapping no longer happens.

Unfortunately this goes beyond my knowledge of Jackson. My gut feeling after debugging tells me that JsonApiary code calls a layer of Jackson where the unwrapping already should have happened and that the JsonApiaryModule calls the wrong method.

Hello,

when I clone the master branch and execute a maven test ; there are failled tests. Can you have a look?

Failing tests are:
loopConstructonTest
complexRelationshipSerializationTest

Thank you!!