cradlepoint / api-samples Goto Github PK

I am attempting to use your script to modify a group where a router is stored. I see your script is created with the intention of modifying a router so I made a few changes to get it to modify the group but am getting the below response when I attempt to run:

Traceback (most recent call last):
File "/home/user/github/netcloudapi/api-samples/configuration/samples/dmvpn_maker/config_pusher.py", line 150, in
push_configs()
File "/home/user/github/netcloudapi/api-samples/configuration/samples/dmvpn_maker/config_pusher.py", line 111, in push_configs
cfg_id = cfg.json().get("data")[0].get("id")
TypeError: 'NoneType' object is not subscriptable

This repository could benefit from being a Python package using setup.py or pyproject.toml.

This way when following the directions on the main README, there could be one extra step to install the package, e.g.

pip install -e /location/of/api-samples

Then the samples could be run pretty seamlessly, and modified in-place with key changes, etc. As it is when trying to run the sample net_device_signal_samples.py I had to manually modify the PYTHONPATH so that the internally-defined monitoring.utils.session package could be correctly imported by Python within the virtual environment.

I could supply a PR if this idea seems good. It's not a big deal, would just make quick operation of the samples a little easier and quicker.