cpw / inventorysorter Goto Github PK

Ok, there's two mods at work here but I don't know which is causing this issue so you both get a post. When using the ender bag, from Ender Utilities, and you middle click to sort your inventory from cpw's inventory sorting mod, everything dupes. Everything in the bag and your inventory. It'll fill your inventory and all of the excess won't be duped.

Here's the link to the post I made on the other mods git: maruohon/enderutilities#18

Similar error like #11.
Game locks up and needs to be force-closed when trying to sort or scroll inside the Cooking for Blockheads Cooking Table (not a standard inventory).

Minecraft 1.9, Forge build 1907, Inventory Sorter 0.7.14+32, Cooking for Blockheads 2.0.10

This is the error:
https://gist.github.com/4rz0/8b71495df07101335d5979b0fb17eec6

Pretty simple. When in gamemode 1 middle click doesn't work but when in gamemode 0 it does.

Playing SF3 and right now when I click the sorting button it simply sorts by quantity. I really REALLY wish I could change this to sort by Mod or item type FIRST then quantity. I know not everyone wants this but the option to change how it actually sorts would be nice.

Version: 0.7.4+26
Pack: FTB experimental
Summery: In the crafting grid, scrolling a result into the inventory using the mouse wheel does not use the ingredients while returning the crafted item. After scrolling, it give the normal return, this will not then give another until the ingredients are removed and replaced. Also works in other crafters, eg. the tcon part builder.
Actions to reproduce: First, craft any patern. Next scroll the result into your inventory. You now can remove the ingredients and repeat.
What I expected to happen: the ingredients to be used up when crafted.
What actually happens: the crafting ingredients are left for collection after giving the results.

https://github.com/cpw/inventorysorter/blob/master/src/main/java/cpw/mods/inventorysorter/KeyHandler.java#L35

This event handler consumes the scroll-wheel mouse event before JEI's recipe view can use it to go to the next/previous pages.

I haven't been able to gather much info on the matter. but it seems like this is a result of the Item Duplication bug a few version ago.
In this scenario though sorting the hotbar while a portable inventory is in it will outright cause it to vanish along with any items in it. This occurs in both Single and Multiplayer.
Re logging on Multiplayer servers does not fix it.

Action#execute is directly called from a packet handler, which is not run on the main thread. This can adversely affect the game and other mods, which expect all interactions to take place on the main thread

When sorting hotbar (with middle click) while inside the GUI of a refined storage wireless crafting grid (or any other refined storage wireless item), it will dupe the item, the dupe taking an empty space in the hotbar. If the hotbar is full, the dupe will replace one (non-refined storage) item until the entire hotbar is filled with wireless crafting grids.

I've been able to reproduce this every time. Tried with other handheld items with GUIs and the dupe does not occur.

This happens in the direwolf20 1.12 modpack version 1.3.0

server log when dupe happens (with RS wireless crafting grid):

[00:21:32] [Server thread/DEBUG] [inventorysorter]: Got action SORT slot 9 [00:21:32] [Server thread/DEBUG] [inventorysorter]: Slot mapping {net.minecraft.inventory.InventoryBasic@1f316d51=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=4, e=12}, net.minecraft.inventory.InventoryBasic@5bde05a7=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@5bde05a7, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=0, e=3}, net.minecraft.inventory.InventoryCraftResult@5c0654bc=InventoryMapping{i=net.minecraft.inventory.InventoryCraftResult@5c0654bc, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=49, e=49}, net.minecraft.inventory.InventoryBasic@307d42d6=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@307d42d6, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=13, e=39}, net.minecraft.inventory.InventoryCrafting@17faf194=InventoryMapping{i=net.minecraft.inventory.InventoryCrafting@17faf194, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=40, e=48}} [00:21:32] [Server thread/DEBUG] [inventorysorter]: Action slot InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=4, e=12} [00:21:32] [Server thread/DEBUG] [inventorysorter]: Item 1xitem.petal@3 is not valid in slot 4 of container com.raoulvdberge.refinedstorage.container.ContainerGrid

with non-RS item (in this case, Traveller's Sack from Actually Additions):

[00:22:43] [Server thread/DEBUG] [inventorysorter]: Got action SORT slot 65 [00:22:43] [Server thread/DEBUG] [inventorysorter]: Slot mapping {net.minecraft.inventory.InventoryBasic@1f316d51=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=de.ellpeck.actuallyadditions.mod.inventory.ContainerBag@5838dad7, b=59, e=67}, net.minecraft.inventory.InventoryBasic@307d42d6=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@307d42d6, c=de.ellpeck.actuallyadditions.mod.inventory.ContainerBag@5838dad7, b=32, e=58}} [00:22:43] [Server thread/DEBUG] [inventorysorter]: Action slot InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=de.ellpeck.actuallyadditions.mod.inventory.ContainerBag@5838dad7, b=59, e=67} [00:22:43] [Server thread/DEBUG] [inventorysorter]: Slot 63 of container de.ellpeck.actuallyadditions.mod.inventory.ContainerBag disallows canTakeStack

This is probably the same problem as #30

I really don't know how to explain it, so I will try to provide as much info as I can. I downloaded the listed version (latest at the time of this issue being opened) and when I was trying to sort my inventory and scroll to move items, and it didn't work. The mod is not disabled, all the configs are on.
This is in a very small modpack I made for myself on curse, the mods are (with versions):
BloodMagic-1.9.4-2.0.1-40
Chameleon-1.9-2.1.4
chiselsandbits-10.2
inventorysorter-1.9.4-0.8.5+39
ironchest-1.9.4-6.0.141.782
jei_1.9.4-3.4.0.204
journeymap-1.9.4-5.2.0-unlimited
JustEnoughResources-1.9.4-0.4.5.31
Psi-beta-33
Quark-beta-21
StorageDrawers-1.9-3.1.7
StorageNetwork-1.9.4-1.11.1
Waila-1.7.0-B3_1.9.4
WailaHarvestability-mc1.9-1.1.7

Not that I think it matters, but Optifine, Fastcraft or any other mod of this type is not present. Just the mods listed.

-Yovli

Azanor/Baubles#184

I middle-clicked an item and the game crashed:
[18:44:44] [Netty Server IO #5/ERROR] [FML]: SimpleChannelHandlerWrapper exception
java.lang.IndexOutOfBoundsException: Index: 32, Size: 0
at java.util.ArrayList.rangeCheck(ArrayList.java:653) ~[?:1.8.0_25]
at java.util.ArrayList.get(ArrayList.java:429) ~[?:1.8.0_25]
at net.minecraft.inventory.Container.func_75139_a(Container.java:113) ~[abd.class:?]
at cpw.mods.inventorysorter.ServerHandler.onMessage(ServerHandler.java:36) ~[ServerHandler.class:?]
at cpw.mods.inventorysorter.ServerHandler.onMessage(ServerHandler.java:30) ~[ServerHandler.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:56) ~[SimpleChannelHandlerWrapper.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:36) ~[SimpleChannelHandlerWrapper.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) ~[SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) [MessageToMessageCodec.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) [DefaultChannelPipeline.class:4.0.23.Final]
at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) [EmbeddedChannel.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:100) [FMLProxyPacket.class:?]
at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:149) [eo.class:?]
at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:51) [eo.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.handleServerSideCustomPacket(NetworkDispatcher.java:446) [NetworkDispatcher.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:269) [NetworkDispatcher.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:73) [NetworkDispatcher.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) [DefaultChannelPipeline.class:4.0.23.Final]
at io.netty.channel.local.LocalChannel.finishPeerRead(LocalChannel.java:326) [LocalChannel.class:4.0.23.Final]
at io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:45) [LocalChannel.class:4.0.23.Final]
at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:312) [LocalChannel$5.class:4.0.23.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380) [SingleThreadEventExecutor.class:4.0.23.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357) [NioEventLoop.class:4.0.23.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [SingleThreadEventExecutor$2.class:4.0.23.Final]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_25]
[18:44:44] [Netty Server IO #5/ERROR] [FML]: There was a critical exception handling a packet on channel inventorysorter
java.lang.IndexOutOfBoundsException: Index: 32, Size: 0
at java.util.ArrayList.rangeCheck(ArrayList.java:653) ~[?:1.8.0_25]
at java.util.ArrayList.get(ArrayList.java:429) ~[?:1.8.0_25]
at net.minecraft.inventory.Container.func_75139_a(Container.java:113) ~[abd.class:?]
at cpw.mods.inventorysorter.ServerHandler.onMessage(ServerHandler.java:36) ~[ServerHandler.class:?]
at cpw.mods.inventorysorter.ServerHandler.onMessage(ServerHandler.java:30) ~[ServerHandler.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:56) ~[SimpleChannelHandlerWrapper.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:36) ~[SimpleChannelHandlerWrapper.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) ~[SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[MessageToMessageDecoder.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) ~[MessageToMessageCodec.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) ~[DefaultChannelPipeline.class:4.0.23.Final]
at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) ~[EmbeddedChannel.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:100) [FMLProxyPacket.class:?]
at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:149) [eo.class:?]
at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:51) [eo.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.handleServerSideCustomPacket(NetworkDispatcher.java:446) [NetworkDispatcher.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:269) [NetworkDispatcher.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:73) [NetworkDispatcher.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) [DefaultChannelPipeline.class:4.0.23.Final]
at io.netty.channel.local.LocalChannel.finishPeerRead(LocalChannel.java:326) [LocalChannel.class:4.0.23.Final]
at io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:45) [LocalChannel.class:4.0.23.Final]
at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:312) [LocalChannel$5.class:4.0.23.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380) [SingleThreadEventExecutor.class:4.0.23.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357) [NioEventLoop.class:4.0.23.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [SingleThreadEventExecutor$2.class:4.0.23.Final]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_25]

When browsing an Applied Energistics Terminal this mods prevents you from scrolling through the list while pointing at an item.

AppliedEnergistics/Applied-Energistics-2#2627

Environment

• Minecraft Version: 1.10.2
• Forge Version: 2135

You could create a config or change the key from the commands ?
I have the middle click broken :
Thanks.

The new chisels and bits bag has stacks of size >64. When I middle clicked to sort it, the server kicked me off. I didn't get any log of it.

I have an inventory that scrolls when using the scroll wheel.

I'm noticing that when I'm hovering over a slot while scrolling, that some scroll values (retrieved through Mouse.getEventDWheel()) are swallowed and are returning 0. This only happens when scrolling OVER a slot.

This makes scrolling harder: it takes more scrolling to get it to actually return a non-0 value.

This issue isn't present when Inventory Sorter isn't installed.

I did add the container AND the slot to the blacklist through IMC. While the scroller features are in fact disabled on the slot and container, it is still conflicting the mouse wheel.

The place where I'm calling Mouse.getEventDWheel() is in GuiScreen#handleMouseInput.

Relevant code:

Scrolling code (aka the Mouse.getEventDWheel() call):
https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/gui/GuiBase.java#L208-L217

IMC blacklisting call (in preInit):
https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/proxy/ProxyCommon.java#L228

https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/integration/inventorysorter/IntegrationInventorySorter.java

(The blacklisting works fine; the behavior is disabled, but it's still swallowing scroll values)

Thank you.

Version:0.7.4+26

When using Neotech's Electric logger in current FTB Unstable if you sort while in it's inventory it duplicates the axe in the 'axe' slot, placing the duplicate in the main inventory of the machine. Also posted on Neotech's bug list.

As a side note it looks like it might be the same issue as the other duplication bugs, but just in case it's not I decided to make a new issue anyway. Sorry if it is the same.

Attempting to sort the animal feeder inventory (because it had been accepting non-feed items) deleted the items in it. Plant Sower & Potion Brewer can be sorted without issue. Spores Reactor, Enchantment Sorter, Petrified Fuel Generator deleted items. I checked for invisible/desync, and replicated in a test world.
IS 1.12.2-1.12.4+ 52
IF 1.12.2-1.6.3-107
Pack: DW20 1.12 1.4.0

IF also has a recently opened issue for this: InnovativeOnlineIndustries/Industrial-Foregoing#129

I'm really missing InventoryTweaks in packs that only have this mod. the list of hotkeys that I use are

Middle Click: Sort
Ctrl-Click/Mousewheel: Move one item
Shift-Click: Move a stack
Alt-Click: Drop a stack
Ctrl-Shift-Click: Move all stacks of item
Alt-Ctrl-Shift-Click: Drop all stacks of item
Space-Click: Move all items
Alt-Space-Click: Drop all items
W-Click: Move item from inventory to container/crafting interface
D-Click: Move item from container/crafting interface to inventory

Would be great if you could add what's missing of these!

I get this crash when I do an inventory sort with the mod Inventory Tweaks. This happened in 1.8 but has returned in 1.9.

Forge: forge-12.16.0.1804
InvTweaks: InventoryTweaks-1.61-dev-44
InvSorter: inventorysorter-1.9-0.7.8+28

http://pastebin.com/DWUNRnzq
*I can upload the full log if needed.

java.lang.IllegalArgumentException: Multiple entries with same key: cpw.mods.inventorysorter.ItemStackHolder@ba8e479d=106 and cpw.mods.inventorysorter.ItemStackHolder@ba8e479d=1664
at com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:150) ~[minecraft_server.1.8.9.jar:?]
at com.google.common.collect.RegularImmutableMap.checkNoConflictInBucket(RegularImmutableMap.java:104) ~[minecraft_server.1.8.9.jar:?]
at com.google.common.collect.RegularImmutableMap.(RegularImmutableMap.java:70) ~[minecraft_server.1.8.9.jar:?]
at com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:254) ~[minecraft_server.1.8.9.jar:?]
at com.google.common.collect.ImmutableMultiset.copyFromEntries(ImmutableMultiset.java:215) ~[minecraft_server.1.8.9.jar:?]
at com.google.common.collect.Multisets.copyHighestCountFirst(Multisets.java:1080) ~[minecraft_server.1.8.9.jar:?]
at cpw.mods.inventorysorter.SortingHandler.apply(SortingHandler.java:44) ~[SortingHandler.class:?]
at cpw.mods.inventorysorter.SortingHandler.apply(SortingHandler.java:34) ~[SortingHandler.class:?]
at cpw.mods.inventorysorter.Action.execute(Action.java:63) ~[Action.class:?]
at cpw.mods.inventorysorter.ServerHandler.onMessage(ServerHandler.java:37) ~[ServerHandler.class:?]
at cpw.mods.inventorysorter.ServerHandler.onMessage(ServerHandler.java:30) ~[ServerHandler.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:37) ~[SimpleChannelHandlerWrapper.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:17) ~[SimpleChannelHandlerWrapper.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) ~[SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[MessageToMessageDecoder.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) ~[MessageToMessageCodec.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) ~[DefaultChannelPipeline.class:4.0.23.Final]
at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) ~[EmbeddedChannel.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:81) [FMLProxyPacket.class:?]
at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:151) [ek.class:?]
at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:54) [ek.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.handleServerSideCustomPacket(NetworkDispatcher.java:425) [NetworkDispatcher.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:248) [NetworkDispatcher.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:53) [NetworkDispatcher.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [SimpleChannelInboundHandler.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:163) [ByteToMessageDecoder.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:163) [ByteToMessageDecoder.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:163) [ByteToMessageDecoder.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:4.0.23.Final]

Furnace and brewing stand can cause dupes with middle click sorting.

Alt+Left clicking an item should drop a stack into the world
Alt+Right Clicking an item should drop a single item into the world

Any possible way that the sorting button can be configurable? Have options to change the middle mouse key to something of our choosing?

Not everyone has a middle mouse button (us poor Mac users for example). It would be great if you'd allow us to configure a different key.

Playing Sky Factory 3, so MC v. 1.10.2 and v. 0.11.0+47 of inventorysorter.

Bug happened when I had converted some loot bags from a higher tier to lower tier which results in stacks of lootbags of 4 - but once you remove them from that stack, they can't get restacked, so what happened was that maybe 10 stacks of 4 lootbags when auto-sorted just filled the inventory and erased some tools of mine and of course some of the remaining loot bags.

You can see it in this gif.

Solved- close this. Thanks!

I know there is someway to access hotkey customization, but I can't find the commands with which to do so.

So if you would just add a list of commands to the read-me that would be amazing!

Bug with Thaumcraft-1.8.9-5.1.4 and inventorysorter-1.8.9-0.7.2+24. Sorting an Arcane Workbench duplicates the wand currently in the workbench.

Sorting the internal inventory of an iron miner from Progressive Automation (1.6.44) results in duplicated tools (specifically the visible items Iron Pickaxe, Iron Shovel, RF Engine. and cobblestone.

Obviously the mod is sorting these items from their respective slots into the internal inventory, but doesn't remove them from the respective slots. The result is duping :(

Stacktrace: https://gist.github.com/shadowfacts/f781f15167bcb17e409b

After the exception, the client freezes and according to the log, the integrated server sees that the player has lost connection, the world saves, however the game does not actually crash. The game freezes and must manually be killed.

When middle click the inventory (doublechest) inside the chest enchanted items (books, and items)
crashing, and NOT crash report. This is my LOG file paste!!!

http://pastebin.com/p63mveMs

Hi @cpw,

While I'm aware this issue has been reported a couple times I thought I'd try to be a bit more in-depth and through with it.

Issue Details

• Minecraft 1.12.2
• Minecraft Forge 14.23.1.2583
• Inventory Sorter 4+52
• Mods Tested w/:
  • Industrial Foregoing 1.6.6 (Items disappear w/ IF)
  • Industrial Craft 2.8.16
  • Extra Utilities 1.7.2

Issue Description

When using various inventories from these mods, with items in, using the middle mouse button will cause the items to duplicate in most cases and sometimes disappear. These are just some of the issues I've had reported I am sure there's many more.

I've tested the three I've mentioned in this post. However, I've heard reports of it happening in the inventory too.

• https://bt.industrial-craft.net/view.php?id=2295
• https://forum.feed-the-beast.com/threads/dupe-bug.263693/
• https://forum.feed-the-beast.com/threads/infinite-ic2-diamond-drills.263753/ (Same as first - The first one was a report I had made to IC2 tracker thinking it was ic2 causing it - that was before I had seen other reports)
• https://ss.blamesnow.co.uk/2018/01/1515113932-3e3f90eb.png (Back when the pack was in testing, testers said it would randomly delete content - which was why it was disabled in Dw20 pack - but now I believe it to be caused by this bug)

Issue Media

Here's a GIF that someone made of the IC2 one https://imgur.com/a/HJSse

Here's a YouTube video that someone else made of Industrial Foregoing experiencing the same issue https://youtu.be/-rcdVK6jw6I

When i scroll my mouse wheel too fast i just pick the item. Using version 1.12.4 +52 of the mod

I've encountered some problem at least 6 or 7 times now (across several versions of SF3 pack) with personal inventory sorting (usually middle-clicking by accident, since I'm using a trackpad) destroying one of my items, and replacing it with a dupe of another item in my inventory.

It doesn't happen often enough (and sometimes I don't notice immediately) to pin down any proximate cause, so any suggestions on ways to debug would be appreciated.

It seems to primarily affect items on my hotbar, and in many (all?) cases I've noticed, it's been duping the item in slot 2 (my RS wireless grid). It always appears to destroy some other item when doing so, which I think is also usually from hotbar (where my nice tools live :()

It has never happened if I disable 'enable middle-click sorting' in the mod-options -> simple inventory sorter config, but I would liek to use it (especially on large chests and other non-player inventories) if I can.

A last note is that it might occur primarily when accessing a modded machine UI that includes the standard player inventory display, and I (mis)-middleclick there. I can't confirm that, and random testing under various conditions hasn't led to reproduction.

Versions:

• minecraft: 1.10.2
• forge: 12.18.3.2215
• inventorysorter: 0.10.5+46
• pack: SkyFactory 3.0.6b

This is caused by the InventorySorter asking for an ItemStack via getStackInSlot() with the slot id -1.
Here's a log of what's happening: http://files.aroma1997.org/tmp/fml-server-latest.log

In a multiplayer server, when scrolling food from the Lunchbox the game does a temporary freeze and kicks you from the server but does not crash the game. When you join back in you have an extra food item in your inventory and still the same one in the Lunchbox. Not sure if this is caused by Spice of Life or Inventory Sorter based on the log. Does not seem to happen in single player

Forge: 2221
Inventory Sorter: 0.10.5+46

Log: http://pastebin.com/PhMyJS4L

This stacktrace is randomly appearing in my console, and I've been told that it may be bad and you shouldn't modify the world directly from packet handlers.

Stacktrace: https://hastebin.com/asolokerem.md

If you have baubles installed, and you open the baubles interface, then you middle click to sort items, it duplicates all items in the armour and baubles slots.

callstack.txt

Above crash log captured when scrolling with inventory open but mouse is not on inventory region.
Also happens in the following UI areas

• Scroll wheel in main menu
• Scroll wheel in World select screen
• Scroll wheel to scroll the keybindings config in options screen

Not sure which to post this at so posting at both.

The mod Cooking for Blockheads has kitchen items like a fridge and counters that have inventory but the sorting feature doesn't work with it.

Would be nice to have a simple config to be able to enable / disable the sorting or wheel individually.

I see some inventories are not supported, which side is responsible for implemeting the sorting feature? InventoryTweaks works but I don't like the fact that the buttons overlaps JEI..

The inventories I am talking about are ironbackpacks ( though ironchests works ) , storage crates from actually additions and I think they are more but just those I found until this moment not working..

Hi @cpw,

Would a debug config option be something you'd consider adding?

It would basically print the inventory a player just sorted to the console (the class name that is) So that you could know which ones to blacklist. This would be more helpful for mods who's code is closed source where you don't really know the class name.

I was sorting an Iron Chest and it went from nearly full to half full. I dug through the logs but couldn't find anything useful. Is there a debug mode or some way I could collect more information for you?

Version 0.10.0+42
Forge 12.18.2.2099

When middle clicking in an armor slot, the armor is duplicated in the main user inventory.

Problem noticed in this pack: https://minecraft.curseforge.com/projects/danny-sirenuse-pack
Inventory Tweaks was not enabled.

Inventory Sorter 1.12.2-1.12.4-52
Extra Utilities 2 1.6.8

I'm not sure if this is Inventory Sorter or Extra Utilities, but... I keep accidentally sorting my golden bag, and every time I do, it doubles the contents of the bag.

I'm using this mod on LAN Multiplayer. On my Laptop it works just fine, on my Desktop (which is also the host) it doesn't.
I've checked the config both in-game and in the txt file.
I have not changed the key binding.
I have not changed the function of the middle-click.

Anything you need from me?

Crash occurs when middle mouse clicking inside a chest to sort it's contents.

Forge Version:
forge 1.9-12.16.0.1865-1.9

Mod Version:
inventorysorter-1.9-0.7.10+29.jar

Crashlog:
http://puu.sh/olAR5/7e0e4745c3.txt

Attempt to download inventorysorter-1.12.2-1.13.1+55.jar from
https://minecraft.curseforge.com/projects/inventory-sorter/files

results in Access Denied.