cpoisson / rent-a-bot Goto Github PK

User story

As an automation client
I want an api to lock a resource knowing it's name or tags
So That I can directly lock the type of resource knowing it's tags, name or id

Acceptance Criterias

One or Multiple resources available

Given one or multiple resources with one or multiple tags
And the resource(s) are available
When requesting a lock using one or multiple tags as criterias
Then A resource is locked and returned within the return informations (resource and lock token)

No resources available

Given one or multiple resources with one or multiple tags
And the resource(s) are not available
When requesting a lock using one or multiple tags as criterias
Then A 403 forbidden resource already locked answer must be returned

No tag(s) match the request

Given one or multiple resources with one or multiple tags
When requesting a lock using one or multiple other tags as criterias
Then A 404 resource not found MUST be returned

I don't see a locking mechanism on database operations.

If I run flask in threaded mode with flask run --with-threads, I can produce race conditions:

• We enter in lock_by_id() 2 times, and it succeeds to lock both times (to reproduce easily, add a sleep on the db operations in controller lock_resource)
• The resource has been locked twice and only the second response lock-token is valid.

Suggestion: use threading.lock or sqlite locks to make the app thread-safe