cperezabo / vscode-language-routeros

Syntax Highlighting for MikroTik RouterOS scripts

Hi there 👋

I'm a passionate software craftsman. Smalltalk and Ruby lover ❤️. Currently working with Ruby, Python, PHP, MongoDB and Angular.

Java sucks 🤮 and, while you read these lines, a new 💩 React state management library is being released.

You can find me ranting on Twitter, always willing to talk about Object thinking, Test-Driven Development and eXtreme Programming.

vscode-language-routeros's Issues

Syntax highlighting error/bug - interprets commands as comments

Issue Type: Bug

Preview this code under ROS extension and note that only the first two lines are colored as commands. 3rd line and after are colored green as comments until the next 'add' is encountered on line 7 and then again the lines following, which contain commands not comments, are colored green.

Also note in the first set of commands I've removed the /r /n line endings but in the second code block they are still there as that is how they are exported. In either case the coloring is still wrong (and both cases should be considered imo).
Screenshot also attached.

/system script
add name=UpdateNTPServers owner=admin policy=read,write,policy,test source="# Script ver 1.1 
# Updated 2015-10-13
/system ntp client set enabled=yes
/system ntp client set primary-ntp=[:resolve us.pool.ntp.org]
/system ntp client set secondary-ntp=[:resolve time.nist.gov]"
add name=sxxxxx owner=admin policy=ftp,reboot,read,write,policy,test,password,sniff,sensitive source=\
    ":log info \"Woke up Sxxxxxxx\"\r\
    \n/tool wol interface=ether5-slave-local\r\
    \nmac=D0:67:E5:

Extension version: 1.0.0
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz (4 x 2494)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: unavailable_software video_decode: enabled video_encode: enabled vpx_decode: unavailable_software webgl: enabled webgl2: enabled
Memory (System)	15.90GB (5.85GB free)
Process Argv	C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader	no
VM	0%

There is no formatter for 'routeros' files installed.

It would be helpful if this extension could help us format our RouterOS scripts. I tried formatting a script using this extension, but an error with the subject of this issue was shown instead of my script being formatted.

https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices

To summarize, an extension that implements the formatting extension API properly will do the following:

1. Register formatters via registerDocumentFormattingEditProvider.
2. Implement the formatting logic per the DocumentFormattingEditProvider interface.
3. Have a setting to enable / disable the formatter.
4. Add the "Formatters" category to the extension manifest.