cp2004 / octoprint-camerastreamer-control

Embed WebRTC (& more) streams provided by camera-streamer in OctoPrint

Hey there 👋

Here are some of my featured projects:

• 🔦 WS281x LED Status

• 🔦 WLED Connection

• ✏️ Marlin EEPROM Editor

• ⚙️ OneDrive Backup

• ⬆️ OctoPrint Upgrade To Python 3

• 📈 Statistics of my plugins: OctoPluginStats

Recent releases 🔖

• ✨ OneDrive File Sync plugin
• Marlin EEPROM Editor 3.3.0
• Gcode Macro 1.3.0
• OneDrive Backup 1.0.1
• WS281x LED Status 0.8.0
• Virtual Printer Settings 2022.07.04
• WLED Connection plugin 0.2.0

Supporting my projects

Enjoyed using a plugin? You can support their development through GitHub Sponsors. Sponsor monthly, one-time and choose a custom amount. You can choose!

❤️ Sponsor

octoprint-camerastreamer-control's Issues

Stream Timeout prevents camera-streamer to stop when browser tab or browser is closed.

Because the stopStream function is using the timeout when called from onWebcamVisibilityChange, the camera-streamer stream is not properly stopped when the user closes the browser tab or browser. (I'm testing in Chrome)

If the code in onWebcamVisibilityChange is changed to self.stopStream(true) (force the stop) or the stream timeout is set to 0 in the settings, everything works as expected.

How to reproduce:
Check CPU usage with top.

1. switch from control tab to any other tab that isn't showing the cam (ex. temp)
   -> camera-streamer CPU usage falls bellow 1%
2. switch back to control tab
   -> camer-streamer usage goes back up (depending on the settings, usually somewhere between 5% - 20%)
3. close chrome tab or browser
   -> camera-streamer CPU usage stays up. Only way to bring it down is to restart the camera-streamer service.

Control tab doesn't append (or prepend) a slash on base URL

I noticed this after setting a custom base URL.

After a discussion on discord with cp2004 the issue is a missing slash.

http://ip:8080/webrtc becomes http://ip:8080webrtc

Dropping this by request so the issue is not forgotton.

📌 Todo list & known issues

I'll try and keep track of the things I know are not implemented or broken in the plugin, so you know if you run into them

TODOs

• Smoother settings UI
• Timeout if webrtc hangs in loading
• Remind user to disable 'Classic webcam' if they would like
• Remind user to select 'Camera Streamer Control' as default webcam if not already
• Expose parameters on the API to clients
• Loading indicator for all stream types
  • WebRTC
  • Mjpg
• Make strings translatable
• Cache buster option

Known issues

• Can't unload mjpg streams on safari, so work around
• Reloads stream on every settings change
• Stream unloads when scrolling down the page (Intersection Observer problem - fixed OctoPrint's side)
• Flip/Rotate does not work on fullscreen/picture in picture - nothing I can do about this

Future features

• Static snapshot stream type
• HLS stream type

Multiple cameras support

Hi,

The only plugin I know of that currently allows you to use multiple cameras, Multicam, does not properly support webrtc streams with the new octopi camera stack.

Looking at the source codes, integrating support for the new camera stack into Multicam seems more complicated than supporting multiple cameras in CamerStreamer-Control.

Considering that the new camera streamer natively supports multiple cameras, could it be within the scope of this project to support multiple cameras too?

Can´t configure webrtc stream URL right

If I put the following URL in a new browser tab (firefox) it shows the webrtc stream in perfect quality:

http://192.168.0.222:8080/webrtc

Pleas note that it needs to be NOT https, and that it needs the ip adress of the raspberry pi/octoprint and the port number of the camera stream, followed by "webrtc".

When I try to configure this URL in your plugin I fail, because in your plugin the part: http://192.168.0.222/ (ip adress with a trailing slash) is hardcoded, so I can´t change it, and only can append something. So if I put :8080/webrtc in the field for the webcam URL it makes the following out of it:

http://192.168.0.222/:8080/webrtc

which will obviously not work, because it pus a hardcoded slash before the port number.
If the slash would not be hardcoded I would be able to put what I need here to get the right URL for the stream. Those who maybee need a slash here could put it manually, and get this to work this way.
The input similar to the ones you have now will change from

"webrtc" to "/webrtc"

same applies to the snapshot URL.
here I would need to get It to work (testet in a firefox tab):

http://192.168.0.222:8080/snapshot

If you put the following:

http://192.168.0.222:8080

you will get a list of functions for the new camera streamer. Every single option listed here works perfectly, as long as it has a leading string like:

http://(ip adress of octoprint/raspi):Port(/option)

and only this syle works, every else fails, despite the fallback to mjpeg stream.

Is it possible to change the hardcoded part in your plugin like so, that the trailing slash is not hardcoded anymore, and has to be put by the user, if necessary?
regards C

Doesn't work with go2rtc webrtc streams

The plugin doesn't seem to be able to handle mp4 webrtc streams generated by go2rtc streamer.

The webrtc url I have is of form:

http://mypi/api/stream.mp4?src=picam_h264

The stream plays just fine in my browser or in apps like mplayer and vlc.
But it fails to display in Octoprint-CameraStreamer-Control (where I selected 'WebRTC' as the Preferred Video Mode)

Any suggestions on troubleshooting this and making it work?

NEVER MIND, I NEED TO UPDATE MY DOCKER IMAGE

NEVER MIND, I NEED TO UPDATE MY DOCKER IMAGE