Air Canada Aeroplan SQD/SQM Calculator

Accessible via https://acsqd.cowtool.com/

ac-sqd's People

Stargazers

Watchers

ac-sqd's Issues

Couple of questions

Hey @scottkennedy, I've got a couple of questions I want to run by you for the acrewardsearcher project. What's the best way to reach out?

Properly return a distance for unknown airlines

This line makes the distance show up as "Unknown" if the airline code is unknown.

https://github.com/scottkennedy/ac-aqd/blob/e134dea8d9d9fc2e153721cff150c6c73030a428/src/main/kotlin/com/canadiancow/aqd/aqm/Calculators.kt#L1027

Even if we can't calculate AQM, we should at least return the distance.

Add support for Azul

https://www.aeroplan.com/earn_miles/our_partners/partner_details.do?Partner=AzulAirlines#/

Calculator cannot handle fare basis codes of Y or J (single character)

AC publishes single character fare basis of "Y" or "J" in North America. (Fares redacted). The referenced code assumes that a fare basis wouldn't only have a single character and would fail on the length. Suggest you check for length of 1 and handle Y as LT and J as EF. (Maybe O as PF although have not seen that)

YTO-SFO       CXR-AC       SAT 01APR23                     USD    
AC-ACR/LT - LATITUDE
AC     YTOSFO          01APR23          
    V FARE BASIS     BK    FARE   TRAVEL-TICKET AP  MINMAX  RTG
  1   YNA0A1LT       Y X   XXX.XX     ----      -/¥  -/  -  634
  2   Y              Y X  XXXX.XX    ----      -    -/  -    1
AC     YTOSFO          01APR23          
    V FARE BASIS     BK    FARE   TRAVEL-TICKET AP  MINMAX  RTG
  1   J              J¥X  XXXX.XX     ----      -    -/  -    1

https://github.com/scottkennedy/ac-aqd/blob/722f038a92bca9219f84bed6548f29a0fd446272/src/main/kotlin/com/cowtool/acsqd/sqm/Calculators.kt#L297