events-backend's Issues
Single Tag API Call
Creating an Event: Location Doesn't Exist
Description
If a location does not exist, the create event form does not allow for the functionality to create a new location. Instead a user must first use /app/post/location/ to create a location and then come back to the create event form.
npm should not be in dependencies
Line 37 in d48e5f6
If you want to enforce npm version, you should use the engine field: https://docs.npmjs.com/files/package.json#engines
No loading indicator while events are loading in web frontend
Remove Commented Backend Code
These code should either be revitalized or killed to avoid future confusion.
TODO List:
- Example 1
events-backend/events_backend/app/forms.py
Lines 66 to 79 in 71b5608
- Example 2
events-backend/events_backend/app/models.py
Lines 122 to 136 in 71b5608
events-backend/events_backend/app/models.py
Lines 245 to 260 in 71b5608
- Example 3
- Example 4
events-backend/events_backend/app/urls.py
Lines 30 to 43 in 71b5608
- Example 5
events-backend/events_backend/app/views.py
Lines 424 to 438 in 71b5608
List of Users: /app/users/ lists superusers
Description:
- If the admins are admin-david, admin-arnav, the API lists:
[{"id":1,"username":"admin-david","org":[]},{"id":2,"username":"admin-arnav","org":[]}]
which gives everyone access to information about the admins.
Suggested Remedy
- Not list the admins that have access to the system (just regular users)
Move secrets
Secrets are present in dev_settings.py, settings_secret.py. Should move off git
Don't pull images from external, non-stable links.
You're loading the App Store and Play Store from Wikipedia links, which are not stable and not intended to be loaded in this way. You should add these assets to your site. Currently, the Play Store logo is broken as a result
Example of external load: https://github.com/cornell-dti/events-backend/blob/master/events_frontend/src/Landing.js#L22
The Play Store assets can be found here: https://play.google.com/intl/en_us/badges/
Login requires CSRF token
Front-end doesn't have CSRF token to send to back-end when attempting to login.
Front end: https://events-site.herokuapp.com/verifyCornellStatus
Back end: https://cuevents-app.herokuapp.com/app/api-auth/login/
Add photo, website to POST org. Associate tags
There's currently no way to POST an organization's website or URL. We must also have a list of tags associated with each organiation.
Remove Commented Frontend Code
These code should either be revitalized or killed to avoid future confusion.
TODO List:
- Example 1
events-backend/events_frontend/src/ChangeOrgEmail.js
Lines 48 to 59 in 71b5608
- Example 2
events-backend/events_frontend/src/ChangePassword.js
Lines 63 to 75 in 71b5608
- Example 3
- Example 4
events-backend/events_frontend/src/routes.js
Lines 2 to 4 in 71b5608
events-backend/events_frontend/src/routes.js
Lines 20 to 21 in 71b5608
events-backend/events_frontend/src/routes.js
Lines 28 to 30 in 71b5608
- Example 5
events-backend/events_frontend/src/components/TagField.js
Lines 45 to 49 in 71b5608
Create an Event: Shouldn't be allowed to choose a diff. organization
API - Endpoint
https://cuevents-app.herokuapp.com/app/post/event/
Description
Creating a new event allows users to choose an organization that is creating the event. In essence, this field should only list the organizations that the signed is user is the owner of, not other organizations. For example, if David owns DTI and Arnav owns CDS or Daily Sun, then when Arnav is creating an event, he should only be allowed to choose CDS or Daily Sun from the organizations. He should not be allowed to choose DTI.
Suggested Remedy
Allow a user to only select events hes the owner to on the form.
May be a law of demeter issue
Requirements: Pillow
I had issue installing Pillow 3.2.0 as part of the install script on both my Mac & Windows laptop; no errors occur when I remove the strict versioning (and install 5.3.0 instead).
Add push to heroku instructions in README
Incorrect page count
Does the same thing as UserDetail
events-backend/backend_main/views.py
Line 424 in 70bec18
As with title.
Seems long and repetitive (DRY principle)
Create a new Event: Incorrect form --> Assertion Error
API - Endpoint
https://cuevents-app.herokuapp.com/app/post/event/
Description
When creating a new event, users don't know what format the date or contact has to be in, it would present it to them so that they know how what to put in.
Suggested Remedy
Change form templates to view formatting/have date picker.
Likely source in Views.py
The post functions doesn't return anything if the form.is_valid() is false
Multiple responsibilities in single API call
events-backend/backend_main/views.py
Line 260 in 70bec18
Can isolate creation of user into a separate API call
Get logged in org ID
We need some way of telling the front-end which organization is the one currently logged in, so it can make the correct API calls with its pk.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.