corb555 / geofinder Goto Github PK

Describe the bug
The install via pip3 claimed success.
When I tried to start by using "geofinder" on the command line, I got a quick popup with "Fatal Error in Launcher" "Unable to create process using '*'"

To Reproduce
Steps to reproduce the behavior:

1. type "geofinder" at command prompt or double-click geofinder.exe in the 'bin' directory of my MSYS2/MINGW64 installation.
2. See error for a couple of seconds, then it disappears.

Desktop (please complete the following information):

• OS: WIN10

Additional context
I also tried starting with "python3 geofinder.py" from the site-packages directory. This at least brought up a gui, although it dumped messages on the command terminal.

I then pressed the 'Quit' button before doing anything else and it did not quit; I had to use the 'x' in the corner to end it. The following was on the console:
C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>python3 geofinder.py
GeoFinder v0.7.4
Python 3.6
GeoFinder Requires Python 3.6 or higher
INFO main.setup_logging 715: geofinder Init
DEBUG main.check_configuration 807: load country selections list
DEBUG geofinder.CachedDictionary.read 52: Read success CachedDict dir=C:\Users\prc\geoname_data\cache fname=country_list.pkl len=0
WARNING main.check_configuration 812: no countries specified
INFO main.check_configuration 818: Found C:\Users\prc\geoname_data\cache\geodata.db
DEBUG geofinder.Config.read 55: config read C:\Users\prc\geoname_data\cache config.pkl
DEBUG geofinder.CachedDictionary.read 52: Read success CachedDict dir=C:\Users\prc\geoname_data\cache fname=config.pkl len=1
DEBUG geofinder.CachedDictionary.write 68: Write C:\Users\prc\geoname_data\cache\config.pkl
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\msys64\mingw64\lib\python3.6\tkinter_init_.py", line 1699, in call
return self.func(*args)
File "geofinder.py", line 748, in shutdown
self.out_diag_file.close()
AttributeError: 'GeoFinder' object has no attribute 'out_diag_file'

Describe the bug
Ran it a couple of times and got slightly different bugs...
To Reproduce
Steps to reproduce the behavior:
Started with "python3 geofinder.py"
C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>python3 geofinder.py
GeoFinder v0.8.0
Python 3.6
GeoFinder Requires Python 3.6 or higher
INFO main.setup_logging 797: geofinder Init
Traceback (most recent call last):
File "geofinder.py", line 949, in
entry()
File "geofinder.py", line 945, in entry
GeoFinder()
File "geofinder.py", line 158, in init
self.ini_set(section='PATH', key='DIRECTORY', val=self.directory)
File "geofinder.py", line 82, in ini_set
self.ini.set(section, key, val)
File "C:\msys64\mingw64\lib\python3.6\configparser.py", line 1192, in set
self._validate_value_types(option=option, value=value)
File "C:\msys64\mingw64\lib\python3.6\configparser.py", line 1177, in _validate_value_types
raise TypeError("option values must be strings")
TypeError: option values must be strings

C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>python3 geofinder.py
GeoFinder v0.8.0
Python 3.6
GeoFinder Requires Python 3.6 or higher
INFO main.setup_logging 797: geofinder Init
Traceback (most recent call last):
File "C:\msys64\mingw64\lib\python3.6\configparser.py", line 789, in get
value = d[option]
File "C:\msys64\mingw64\lib\python3.6\collections_init_.py", line 883, in getitem
return self.missing(key) # support subclasses that define missing
File "C:\msys64\mingw64\lib\python3.6\collections_init_.py", line 875, in missing
raise KeyError(key)
KeyError: 'directory'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "geofinder.py", line 949, in
entry()
File "geofinder.py", line 945, in entry
GeoFinder()
File "geofinder.py", line 153, in init
self.directory = Path(self.ini_read('PATH', 'DIRECTORY'))
File "geofinder.py", line 78, in ini_read
return self.ini.get(section, key)
File "C:\msys64\mingw64\lib\python3.6\configparser.py", line 792, in get
raise NoOptionError(option, section)
configparser.NoOptionError: No option 'directory' in section: 'PATH'

Desktop (please complete the following information):

• OS: Win10
  Msys2/Mingw64 environment (older, not recently updated versions with Python3.6)

Describe the bug
The column sizing of the Score and Type columns is not wide enough to display the title and in some cases the Type.

It may be because my system doesn't have a Helvetica font, so chose an inappropriate font which displays larger.
Also, the font is really quite a bit larger than usual or necessary for my system which cuts off some the the items in the Location and Prefix columns.

Desktop (please complete the following information):

• OS: Win10

When I add places, I am easily confused by the use of the Quit button. If it does what the manual says, meaning to save the configuration, I would expect it be called Save, and to either close the window, or to provide some feedback that my settings were saved, and I can close the window with the X in the upper right corner. Right now, I don't see that type of feedback.
Moreover, if I were to click that X after changing things, I would expect to see a warning, so that I can still save things.

Great initiative, and it look promising, but...
On Windows at least, its important to be able to chose where to store data when it is as large as files as the geonames file.
Same with the database store, its important that its possible to create your own "database folder".

i.e.
I don't use C:\ for anything but OS and software files/config files... I have separate disks/SSD's for different type of content...

Is your feature request related to a problem? Please describe.
It would be nice to be able to go back to the original search line when trying to edit for a better match. I think that tkinter allows undo/redo https://stackoverflow.com/questions/3169344/undo-and-redo-features-in-a-tkinter-text-widget

Which seems like a reasonable way to support this.

If you follow the standard instructions for Windows, pip will still not work from the command prompt. Please advise users to select the option to add all programs to the PATH in the Python setup dialog.

Is your feature request related to a problem? Please describe.
I have some places that are located in the county, not a city, for example
"325 CR45, xyz county, ohio, usa" (CR stands for county road)

While the "325 CR45" ends up described as a prefix, there are no results that just include the county, they all seem to be trying to treat the county position as a city.

Describe the solution you'd like
When the front place in a full string like this occurs, but is not found, put at least some effort into finding the latter three as county, state, country, with the prefix described as the leading element.

Describe the bug
I have no idea what is going on here. 0.8.4 won't install. I tried to install 0.8.2 and 0.8.3, they both installed fine. There is something weird happening with the path names; looks like it stuttered on build/lib. If it is doing that for real, the path is possibly getting too long for Windows (256 chars max). Session log attached.

It would be helpful if there was a version # somewhere in the GUI to see what was actually running...

C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>pip3 install geofinder --upgrade
Collecting geofinder
Using cached https://files.pythonhosted.org/packages/4b/d9/82775cbe139ed86a3f4833a986f6bb89c7f12ff88150d1b0b09a4425e33b/geofinder-0.8.4-py3-none-any.whl
ERROR: Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: 'C:\Users\prc\AppData\Local\Temp\pip-install-y7xqzjfg\geofinder\build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/geofinder/AlternateNames.py'

C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>pip3 install geofinder==0.8.2
Collecting geofinder==0.8.2
Downloading https://files.pythonhosted.org/packages/f3/1c/d2172eefdc9c491ade79f258515b211456ace71e76b1723ad2afc570d2fb/geofinder-0.8.2-py3-none-any.whl (2.3MB)
|████████████████████████████████| 2.3MB 2.2MB/s
Requirement already satisfied: unidecode in c:\msys64\mingw64\lib\python3.6\site-packages (from geofinder==0.8.2) (1.1.1)
Requirement already satisfied: phonetics in c:\msys64\mingw64\lib\python3.6\site-packages (from geofinder==0.8.2) (1.0.5)
Installing collected packages: geofinder
Found existing installation: geofinder 0.8.0
Uninstalling geofinder-0.8.0:
Successfully installed geofinder-0.8.2

C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>pip3 install geofinder==0.8.3
Collecting geofinder==0.8.3
Downloading https://files.pythonhosted.org/packages/8d/d3/7727982c89ed20a5679cb37702e71db8f7003216c620de8cce7ce6c878bb/geofinder-0.8.3-py3-none-any.whl (2.4MB)
|████████████████████████████████| 2.4MB 2.2MB/s
Requirement already satisfied: unidecode in c:\msys64\mingw64\lib\python3.6\site-packages (from geofinder==0.8.3) (1.1.1)
Requirement already satisfied: phonetics in c:\msys64\mingw64\lib\python3.6\site-packages (from geofinder==0.8.3) (1.0.5)
Installing collected packages: geofinder
Found existing installation: geofinder 0.8.2
Uninstalling geofinder-0.8.2:
Successfully installed geofinder-0.8.3

C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>pip3 install geofinder==0.8.4
Collecting geofinder==0.8.4
Using cached https://files.pythonhosted.org/packages/4b/d9/82775cbe139ed86a3f4833a986f6bb89c7f12ff88150d1b0b09a4425e33b/geofinder-0.8.4-py3-none-any.whl
ERROR: Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: 'C:\Users\prc\AppData\Local\Temp\pip-install-77k3we_b\geofinder\build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/geofinder/AlternateNames.py'

Win10 Msys2/Mingw64 environment.

Describe the bug
If you press the 'X' on the initial screen, Geofinder doesn't shut down.

To Reproduce
Steps to reproduce the behavior:
I then pressed the 'Quit' button before doing anything else and it did not quit; I had to use the 'x' in the corner to end it. The following was on the console:
C:\msys64\mingw64\lib\python3.6\site-packages\geofinder>python3 geofinder.py
GeoFinder v0.7.4
Python 3.6
GeoFinder Requires Python 3.6 or higher
INFO main.setup_logging 715: geofinder Init
File "geofinder.py", line 748, in shutdown
self.out_diag_file.close()
AttributeError: 'GeoFinder' object has no attribute 'out_diag_file'

Expected behavior
'X' should cause shutdown

Desktop (please complete the following information):

• OS: Win10

Describe the bug
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\msys64\mingw64\lib\python3.6\tkinter_init_.py", line 1699, in call
return self.func(*args)
File "C:\msys64\mingw64\lib\python3.6\site-packages\geofinder\GeoFinder.py", line 682, in quit_handler
self.handle_place_entry()
File "C:\msys64\mingw64\lib\python3.6\site-packages\geofinder\GeoFinder.py", line 325, in handle_place_entry
self.end_of_file_shutdown()
File "C:\msys64\mingw64\lib\python3.6\site-packages\geofinder\GeoFinder.py", line 842, in end_of_file_shutdown
os.remove(f"{path}.{self.out_suffix}")
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'C:/Users/prc/workspace/Gramps2/works_2019-11-03.gramps.import.gramps'

To Reproduce
Steps to reproduce the behavior:

1. Open and work on file
2. quit
3. Say yes to Generate Import File

OS: Win10

Describe the bug
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\msys64\mingw64\lib\python3.6\tkinter_init_.py", line 1699, in call
return self.func(*args)
File "C:\Users\prc\workspace\Geofinder\GeoFinder\geofinder\UtilLayout.py", line 158, in quit_handler
os.remove(path)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\Users\prc\geoname_data\cache\geodata.db'

To Reproduce
Steps to reproduce the behavior:

1. Enter config
2. Change a config value that suggest a db rebuild (I used the Features list to add 'PO' for post office)
3. Quit, and say yes to "Configuration Changed" message.

You cannot quit and ask for change, ends up back in config dialog. You can say not to change, and quit. But db won't be rebuilt.

I think this is another case where the db has to be closed to delete it.
I deleted it manually to make progress.

OS: WIN10