cooptilleuls / cooptilleulsymlpbundle Goto Github PK

Il faudrait faire un package.json

in .gitignore, line 3

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

composer.lock
composer.phar
vendor

Posted from SensioLabsInsight

Use Guzzle http://docs.guzzlephp.org/en/latest/ instead of the custom CURL thing.

The checker detected 1 security issues in package symfony/http-kernel installed in version 2.5.2.0 1) Direct access of ESI URLs behind a trusted proxy.

Posted from SensioLabsInsight

in .travis.yml, line 16

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

script: vendor/bin/phpspec run

matrix:
  allow_failures:
    - php: hhvm

Posted from SensioLabsInsight

Create a .travis.yml file to launch tests with PHP 5.3, 5.4 et 5.5, avec SF 2.3 et 2.4

in LICENSE, line 19

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

Posted from SensioLabsInsight

And it should be true.

Use PHPSpec to write them and update the .travis.yml file accordingly.

If YMLP provide a test environment, you can also write functional tests using it.

Because in Symfony requirements, PHP version is at least 5.3.3 and simple array notation ([...]) was introduced in 5.4 you shouldn't use this notation.

For public bundles, XML must be preferred because it can be tested against XSD and have a better support in IDE.