Coder Social home page Coder Social logo

Comments (3)

msgilligan avatar msgilligan commented on June 14, 2024

I think you found a bug. It looks like the RawTransactionInfo constructor that takes a Transaction has never been used or tested before.

I think the correct code should be:

        vin = new VinList();
        for (TransactionInput input : transaction.getInputs()) {
            vin.add(new Vin(txid,
                            input.getOutpoint().getIndex(),
                            input.getScriptSig().toString(),
                            input.getSequenceNumber()));
        }

thus using transaction.getHash() for each of the inputs.

from consensusj.

msgilligan avatar msgilligan commented on June 14, 2024

#36 should fix the problem. @barrongineer can you review the PR and/or test the change in your code?

from consensusj.

msgilligan avatar msgilligan commented on June 14, 2024

Closing as fixed (#36)

from consensusj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.