Comments (3)
@msgilligan Opinions on this?
from consensusj.
Sorry for not responding sooner. I don't have a strong opinion prima facie, you could use a subclass or maybe the composition-over-inheritence principle applies here. So there are at least two choices:
- Make it a subclass
- Make it a separate service (that perhaps takes a
WalletAppKitService
in its constructor, if needed)
Use your best judgement and code something up. We can review it and refactor if we think refactoring can improve it.
from consensusj.
Closing. See #25 and #69 (comment)
from consensusj.
Related Issues (20)
- JsonRpcRequest: support params as maps (JSON-RPC 2.0 feature)
- JsonRpcServiceWrapper: use Jackson to map to custom types (after method is identified)
- Upgrade consensusj-jsonrpc and dependents to Java 17
- Numeric value (2345908848) out of range of int HOT 5
- Field "frozen" added to balance results HOT 1
- getRawTransaction hexEncoded Parse error HOT 2
- Upgrade to Spring Boot 2.1.x HOT 1
- I want to use jsonrpc to connect bitcoind. What should I do? HOT 2
- Write User Guide
- JavaDoc (AsciiDoclet) won't build on JDK 11 HOT 2
- Add new Bitcoin RPC Method: generatetoaddress HOT 2
- Upgrade CLI modules to JDK 9 and use ToolProvider interface HOT 1
- Gradle build: migrate from deprecated `maven` plugin to `maven-publish` plugin HOT 1
- Resolve publishing issues with Spring Boot subprojects HOT 1
- Remove Spring Boot and Ratpack-based server apps HOT 5
- jakarta.inject migration is not complete HOT 3
- Publish jars on artifact repository (Bintray shutdown) HOT 5
- Publish to Maven Central
- Re-enable AsciiDoclet?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from consensusj.