conduit-innovation / gorilla-claw Goto Github PK

It makes sense to me that developers will need to perf check any hooks they monkey-patch in some way.

It would be nice to include a basic API for this. Perhaps something like:

define('GORILLA_PROFILE', true);

/* Do something with hooks */

gorillaclaw_perf_report();

Feature criteria:

• Need: Minimal performance impact
• Need: No performance impact when disabled (default)
• Want: Some kind of machine readable output, so we can integrate with CI pipelines

Cannot access the original scope / $this from within injected handlers.

$hooks->inject(function($input) {
            $this->{'id'} = 1;
            return $input . '-before-' . $this->{'get_private_id'}();
        }, function($input) {
            $this->{'id'} = 2;
            return $input . '-after-' . $this->{'get_id'}();
        });

Throws: Error: Call to undefined method GorillaClaw\Test\HookTest::get_private_id()

It should be possible to intercept calls / accesses made by a handler to $this, without replacing the original handler.

This means we can register on_call type events that are fired when a filter / action handler tries to access it's own $this. We can then either return a new value to skip execution of the $this->some_method() call, or return null to allow the call to continue.

This is a huge rabbit hole, and will need some thought. In theory we could pre and post process any object accessor similar to how we inject().

• Create event trigger / handler subsystem
• Intercept object method calls
• Override and skip object method calls
• Intercept property accesses
• Intercept property writes
• Recursive HookProxy works (ie. proxying-a-proxy should proxy the original object)

Branch feature/intercept tracks this feature.