concretecms / concrete5-legacy

Legacy repository for concrete5

    c5c5c5c5c5c5c5c5c5c5c5c5c5c5c5c
   c5c5c5c5c5c5c5c5c-c5c5c5c5c5c5c5c
 | c5c5c5c5c5--c5c5   5c5c5c5c5c5c5c
 | c5c5c5c5c   c5c5   c5c5c.5c5c5c5c
 | c5c5c5c5c.  c5c5   c5c5  :c5c5c5c
 | c5c- .c5c5   5c5   c5c.  5c5c5c5c
 | c5c5  :c5c   c5c.  c5c  '5c5c5c5c                              .,
 | c5c5:  c5c:  c5c5 .c5.  c5c5c5c5c                              /c-._
 | c5c5c. :5c5c-c5c5-5c5:.5c5c5c5c5c                           --/c5c5c\
 | c5c5c5c.5c5:.       .:c5c5c5c5c5c                       .--/c5c5c5c5c5c\
 | c5c5c5c5.             .c5c5-.5c5c                   __-"5c5c5c5c5c5c5c5c'-._
 | c5c5c5c     .c5c5c5c5c5c5.   .c5c                _-/c5c5c5-5.-"'-c5c5c5c5c5c\_           _____
 | c5c5c5      5c5c5c5c5c5.    c5c5c         _.,-='"c-*-:;   *,      '"*5c5c5c5c5"--__     / ____]
 | c5c5c5:     :c5c5c5c5.    :5c5c5c     -"""c5; c5c    `      '           '"'_'"""'- "'- / /___
 | c5c5c5c:      .c5c.     :5c5c5c5c     ___   ___   _ _    ___  _ _   ___  _| |_   _ _  / ___  \
 | c5c5c5c5c5:.         .c5c5c5c5c5c    /  _] /   \ |   \  /  _]|  _] /   \|_   _| /   \ __    \ \
 | c5c5c5c5c5c5c5c5c5c5c5c5c5c5c5c5c   (  (_ (     )| || |(  (_ | /  (  ---  | |_ (  --- \ \ _ / /
 \  c5c5c5c5c5c5c5c5c5c5c5c5c5c5c5c    \\___]\\___/||_||_|\\___]|_|  \\___/ \\___]\\___/ \\_____/
   ------------------------------        --    --   -- --   --  --     --     --    --     ----

Legacy Version

This is the legacy version of Concrete5. It is still being actively maintained, but significant development and new features are a part of Version 5.7 and greater. New versions of concrete5 can be found in this repository: http://github.com/concrete5/concrete5/

Note

This is the development distribution of concrete5 Legacy. It is bleeding edge. The latest development build can be downloaded from https://github.com/concrete5/concrete5-legacy/zipball/master.

For the latest fully supported release, check out http://www.concrete5.org/download/

Installation Instructions for concrete5

1. Make sure your config/, packages/ and files/ directories are writable by a web server. These directories are in the root of the archive. This can either be done by making the owner of the directories the web server user, or by making them world writable using chmod 777 (in Linux/OS X.)
2. Create a new MySQL database and a MySQL user account with the following privileges on that database: INSERT, SELECT, UPDATE, DELETE, CREATE, DROP, ALTER
3. Visit your concrete5 site in your web browser. You should see an installation screen where you can specify your site's name, your base URL, and your database settings, and the rest of the information necessary to install concrete5.
4. Click through and wait for the installation to complete.
5. concrete5 should be installed.

Documentation

http://concrete5.org/documentation/

Code Submissions

http://www.concrete5.org/developers/submitting-code/submitting_code_to_concrete/

Short Tags

The concrete5 git repository currently uses php "short tags". Pull requests should maintain this convention. Final release versions have short tags converted to long tags. Note: This issue has thoroughly discussed. Currently the shed is red but may be painted green in the future.

If short tags are not enabled in your development environment you can enable them either

• In php.ini add short_open_tag = On
• In Apache .htaccess add php_value short_open_tag 1

Building Assets

You do not need to build assets in order to run the github master This is only needed if you are hacking core javascript and css. For further details see the build folder.

concrete5-legacy's Issues

Stacks/Composer Pages should be system pages

mark stacks/composer drafts as system pages page in database

test

test

Page search, & sitemap behavior

Kill sitemap as an overlay.
Add "Your Pages: " as a section to intelligent search.

Clicking sitemap from quicknav bar simply takes you to dashboard.

Deleting a user does not delete attributes.

When you delete a user, their attributes are still in the database (UserSearchIndexAttributes table)

Pagination Helper JS Functionality GONE!

May I ask why the jsFunctionCall property and associated functionality was removed from the PaginationHelper class? It completely breaks one of my add-ons! I can't see where it would cause any compatibility issues, but I thought I'd inquire to see if there's a compelling reason to eradicate that code.

Any chance it can be added back in before 5.5 is released? I'd be happy to add it back and submit the changes via Github. Its absence creates an unnecessary and non-trivial amount of work for me to make my add-on functional again.

If it was removed for good reason, please fill me in on the proper approach to use in its place.

Thanks!

-Steve

Add "Back to" where it makes sense

We've added the ability to specify "back to" links that show up when hoving over dashboard pane titles. Check out the User attributes and composer pages for examples of this. we need to add this to reports, pages and themes, members, stacks and blocks, add functionality and the system and settings sections (where they make sense.) All system and settings pages should basically link back to system and settings.

Remove "back" buttons that have been placed manually if you find them.

Dashboard navigation and close buttons are very confusing

The "X" close buttons on the dashboard windows don't actually do anything useful (they close the dialog but it just leaves you with an empty page, which makes no sense). I propose that the "X" button be removed from those dialogs entirely, except for the items that are categorized under "System & Settings", which should bring you back to the main "System & Settings" window when the "X" is clicked. (The main "Systems & Settings" menu itself should not have the "X" button though).

Also, I propose that after clicking the "Save" or "Update" button to update a system setting, it should bring you back to the main "System & Settings" window, instead of just leaving you on the same page you were just on.

Site Permissions

"Set permissions for common concrete5 tasks."
->
"Set administrative access details."

Duplicate Quick Links

if you double click the link to add a quick link the link doesn't get removed and the next click makes another quick link for that page. http://imgur.com/FaBiL

clear cache

the blue button and footer treatment should go away

"Clear Cache" should be a grey button inline, left aligned after the paragraph

Guestbook Tidbits

please correct errors makes errors super hard to find, I didn't see the message next to captcha.. Thse should be more strongly formatted if inline, or stacked up top if not.

guestbook should honor naughty word list

rich text editor settings

Max width should be validation message not inline, remove it from the page and throw an alert back if too small.

It also doesn't seem to actually honor size any more on the front end at all.

Can we have a preview of what tinyMCE will look like for all the modes, plus custom?
If not can we at least have some screenshots of what the toolbars will be for the modes, which the custom text area would then replace?

dashboard/system/attributes/sets/category/1/ - Collection Attribute Sets UI

lose back to categories button, blue add set button, and footer treatment.

Add a grey Add Set button under the name field.

Lose "Group attributes into sets for better organization and management."

Styling on error modal dialog on invalid block add submit

I'm going round in circles trying to find where to stick styling on this (best i've found is concrete > tools > alert.php) but the block submit error pane that's thrown up when a block is submitted without correct info (eg. save File block without selecting a file) probably needs some styling TLC -- at the very least, a nice bootstrap 'btn error' style close button.

Unable to upgrade 5.4.2.2 to beta

currently when I try to upgrade I get

Fatal error: Call to a member function update() on a non-object in /git/web/concrete/helpers/concrete/upgrade/version_550.php on line 77

POT File should be included

Since some strings are added dynamically to t(), it means they will not be discovered by the automatic code scanning. So I think it would make sense to include a pot file in the standard distribution. This one could be used a a starting point: http://www.concrete5.org/community/forums/internationalization/german-translation-of-5-5/#237086
To compile the list of dynamically added strings the logging functionality of Zend translate can be used: http://framework.zend.com/manual/1.11/en/zend.translate.additional.html#zend.translate.additional.logging
Just click though all relevant backend pages and then do a:
sort log.txt | uniq

Environment Page

environment page gives error:

Warning: Cannot modify header information - headers already sent by (output started at /Applications/MAMP/htdocs/55alpha/concrete/controllers/dashboard/system/environment/info.php:1) in /Applications/MAMP/htdocs/55alpha/concrete/libraries/view.php on line 815

Maintenance Mode

Window is too wide, use smaller footprint version.

system & settings page

titles shouldn't link at all, it's odd having them link to first child.

Debug Level

Set debug level ->
Save

Move save to right.

lose paragraph up top in blue bar.

remove grey explanations
change labels to:
"Show Errors In Page"
"Hide Errors From Site Visitors"

Concrete5 Logo Click Behavior Missing on Site Page

I don't know if this is intentional or not, but the C5 logo does nothing when clicked if you're on a page of the site (versus being on a dashboard page). I can't think of any reason it should behave any differently in that context. In fact, it's likely to cause confusion because it looks exactly the same in either context, so most users (myself included) would expect it to behave the same.

-Steve

Filemanager & User Search UI tweaks

Move result count to bottom of results close to paging.
Move export (on users) to same neighborhood.

Move "With selected" to the left, above the select check boxes

Tighten up keyword search, sets, and paging to fit all in one line
Flip the carrots on advanced (everywhere) it points the direction that something WILL move when you click it, so when closed points down, when open points up.

Move customize results into advanced search.
Move any other search fields into advanced search
Add an "Additional Filters" label to the additional filters section

Lose the tabs on add file/search.
Move upload UI to upper right.
Try to use a different color for the upload multiple button
Change the first "Choose File" label to Add File(s)

Lets' add a "Add User" blue button to the upper right of the user search UI - and start using that as a rule where it makes sense for category/detail

Guestbook Options Window is Tiny

Why so small? Can we make this window a bigger footprint?

sitename settings

change blue button to simply be "Save" and right aligned in the footer

single page list is huge

Just swap the order of the add single page and complete list so add single page is at the top.

Replace file and upload error need styling

Deleting Saved search

deleting a saved search gives error:
mysql error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1] in EXECUTE("DELETE FROM FileSets WHERE fsID = ")

File rescan needs styling

Environment

can we add a "copy to clipboard" grey button to a paneFooter on this page?

dashboard/system/permissions/files/

Change title to "File Manager Permissions"

Change form field type from radio buttons to the select drop down.
My hope is that will tighten up the space a bit so this page doesn't get so dramatically long so quickly as you add new users/groups

Add Files Multiple Window UI tweaks

Can we put Cancel/Start in the floating grey footer we sometimes use?
Can we rename buttons to Cancel | Start Uploads

Also can we move max upload info up to the top right, where it doesn't get lost and might help impact decisions. Also doesnt need to be this bold/big.

On results, we need some "Continue" button that closes the window. Even tho I know all these options are ajax save, it seems really odd to hit X to get out of here... like "Did I actually upload?"... calling it "Continue" instead of "Save" should help make eveyrone happy.

Preview on autonav

For some reason the bullets look off on preview in autonav. I see everything flat, with Home's bullet hanging way off to the right.

/system/attributes/sets/edit/1 - the edit set UI

turn blue buttons into grey ones. Leave delete red.

Lose the grey background style on all three buttons

Logging

Save Logging Settings ->
Save

Move to right.

Add File Set

Remove this from the dashboard drop down in the tool bar.
Add this to the upper right of the File Sets UI page, just like we will have for add file

5.5 quick filter doesn't check ENABLE_MARKETPLACE_SUPPORT

I was trying to disable the marketplace lookup when I enter a word like "form". There used to be a constant called ENABLE_MARKETPLACE_SUPPORT which we could set to false to get rid of all the marketplace integration.

Couldn't find anything in the JavaScript code which is related to that.

There might be another constant which I haven't found but if there isn't there should probably be one.

Thanks!
Remo

cache & speed settings

lose this paragraph:
"Caching stores frequently accessed data so it can be more quickly retrieved. Full page caching can dramatically lighten the load on your server and speed up your website, and is highly recommended in high traffic situations."

Change to look like:

Basic Cache
Off - Good for development.
On - Helps speed up a live site.

Full Page Caching
Off - Turn it on by hand for specific pages.
On - If blocks allow it.
On - In all cases.

Full Page Cache Rebuild
Automatic
Every [ ] minutes
Manually cleared

Move blue button to right, call it "Save"

file sets search

file sets: keyword search on left, type after that.

Get more themes button

This should be a blue button, not just a text link.
Either put it where the text link is, or put it at the end of the theme scroller

Title of "Sitewide Mail Settings" -> "SMTP Method"

The title in the page should be "SMTP Method"

file sets dialog looks weird

File Storage Locations

Add "Path" label to first from field for consistency sake.

Kill the explanation sentences:
"Enter the directory where files will be stored on this server by default."

"Enter the name and path of an optional, additional location for file storage."

Trying to use save search

When trying to use a saved search:
Fatal error: Call to a member function getDefaultSortColumn() on a non-object in /Applications/MAMP/htdocs/55alpha/concrete/controllers/dashboard/files/search.php on line 40

Toolbar Sitemap Button Style Issue

A minor style tweak is needed for the Sitemap button in the toolbar...

http://temp.perceptualmediaworks.com/2011-11-21_1100.png

-Steve

Block Types UI

Add a message to the end of /blocks/types

More Blocks
Browse our marketplace of Add-ons to extend your site!
More Add-ons

Public Registration

Change to:

Allow visitors to signup as site members?
<> Off
<> On - email validation
<> On - approve manually.
<> On - signup and go.

Options:
[ ] CAPTCHA required
[ ] use eMails for login
[ ] enable OpenID

Pagination Not Working Properly When Viewing Versions

When viewing a list of page versions (Edit -> Versions), using the pagination UI results in the entire page being refreshed with the list contents.

-Steve

Revisiting item in history bar should move that item to the far right

When you visit a page, that page is added to the right side of the history bar (under the admin toolbar). But if you visit a page that's already in the history bar, it does not move over to the right. I think it should because the expectation is that the history bar shows the last pages visited, in the order they were visited.

timezone settings

Loose the grey explanation text.
move the save button over to the right.

bookmark icons

Add a title above the choose file space: Favicon

Duplicate that section styles then, and add support for iphone icon.
Title: iPhone Thumbnail

Same type of messaging about size and upload functionality.

Save button becomes two grey Upload buttons inline.
Lose the footer nav space.