concordium / concordium-dapp-libraries Goto Github PK

It doesn't make sense to make a release without any changes worth mentioning. We should therefore require that the extracted change isn't empty and have the workflow verify this.

In the (unforseen) case that the message in the annotated tag is in fact sufficient, we might add a boolean input flag to either allow the changelog to be empty or not attempt to extract it at all. Either way, the "Changelog" section of the release notes should be included only if it's followed by any entries.

We might also want to add flags for skipping other actions like publishing to npm or GitHub. But more likely we should split the workflow such that the current one only publishes to GitHub. Publishing to npm will happen in a separate workflow which is triggered automatically by a publish to GitHub. This allows the possibility of manual GitHub releases to automatically sync to the npm registry.

It would also be neat if a message announcing the release was automatically posted to the appropriate Slack channel.

This task is a followup to #39.

Description
There's a few methods that are in the Wallet Api but not in this library.

I'm currently writing Dapp codes with React and on my way to refactor Wallet connection logic with this library, replacing Wallet Api with this library.
For now everything seems to be fine except above point. e.g. addCIS2Tokens

Task description
With Concordium/concordium-node-sdk-js#271, the web sdk receives a major upgrade, making it tree-shakable. As such, we should upgrade the dependency here (or perhaps make it a peer dependency?)

The implementation is probably a no-op for Browser Wallet, but WalletConnect has an actual endpoint that should be used.

The piggybank dApp has been using this to detect connection loss for WalletConnect.

The "send" methods of WalletConnection currently accepts the sender account as a parameter. This seems redundant to me as I can't imagine a case where this wouldn't be the currently connected account. The implementation should therefore always just use this account.

The WithWalletConnector component is currently logging events on the debug and info levels. Ensure that we only log on debug and only what's strictly useful.

When the browser wallet is released with the updated wallet API, the libraries included in this repository should be updated to point to the official release of @concordium/browser-wallet-api-helpers.

Task description
Move the WALLET_CONNECT_PROJECT_ID constant into the walletConnect library since it has to be reused by outside developers.

const WALLET_CONNECT_PROJECT_ID = '76324905a70fe5c388bab46d3e0564dc';

Concordium/concordium-browser-wallet#260 (comment)

https://concordium.slack.com/archives/C037WKK99NE/p1679042051884009?thread_ts=1679041309.052459&cid=C037WKK99NE

The WALLET_CONNECT_PROJECT_ID, is the ID allocated to the account that Concordium has with walletconnect. Other dApp developers should use the same number. It is the ID for our wallets, so walletconnect knows which app to open a connection with.

This is clear when using the browser wallet as the popup opens inside the field of view. But for WalletConnect it isn't clear to the user that they should switch attention to their phone.

If the solution turns out to be generic it would make sense to add it to react-components.