commander07 / data-loader Goto Github PK

I'm really interested in this mod. It's annoying that Mojang didn't consider this concept on vanilla.

The only change i would love to see is the datapacks folder to be yanked out of config and placed on .minecraft\/Game Directory folder root, to be paired with resourcepack and look more how vanilla should implement this feature themselves.

I know there is a couple of alternatives out there, but this one, being simple as that, is my favorite implementation.

Context :
Minecraft 1.20.4
fabricloader 0.15.3
dataloader 1.1.4

When I start my server with only fabric-api and dataloader I have the following error : latest.log

This mod does not work on Quilt with the standard QFAPI; it crashes when trying to enter a world or load the Create New World screen; see https://mclo.gs/3emFHB8. Iʼm not sure I quite follow the reasons why, but someone on the Quilt server suggested that if you changed https://github.com/Commander07/data-loader/blob/master/src/main/java/dataloader/mixin/MinecraftServerMixin.java#L18 to inject at TAIL instead of HEAD it should work. They also said itʼd be recommended to use the Resource Loader API instead of using that directly.

I have not yet tried to build and test this change myself, which is why Iʼm not making a PR.

Well, just for curiosity and tried to place Data Loader in a test 1.20.5-rc2 profile (with only Fabric API) to see if it would boot (like it did with 1.20.3 and 1.20.4). Unfortunately not. I think a mixin error.

For the sake of information (and maybe help showing what parts need to be changed for a 1.20.5 port), here's the crash log:
https://gist.github.com/vico93/2cd43eea6e6192751b52502bd5c7eb93

Basically, i'm using Custom Piglin Bartering to fix some stuff about piglins, it cames with two internal datapacks: default_custom_piglin_barters and vanilla_piglin_barters.

I tried to put them in the loadOrder field in data-loader.json with either colon or slashes separating the mod id (eg.: "custom_piglin_bartening:vanilla_piglin_barters" or "custom_piglin_bartening/vanilla_piglin_barters") and the datapack name, but in both cases the datapacks weren't preadded to the activated datapack list in singleplayer.

What i'm doing wrong - or data loader is even able to fetch mod internal datapacks like it does with vanilla ones?

I wonder if this mod could load a user-made load order of datapacks - consisting of a list of file/folder names (including internal packs like vanilla and fabric and the experimental bundle) in order to be mirrored everytime the player creates a world in singleplayer. For dedicated servers i feel the initial-enabled-packs directive on server.properties already serves for this purpose, but on singleplayer everytime we create a world we need to sort all the packs again, and if there is a huge number of packs to be loaded this would end up as a huge nuisiance.

Basically, on the Select Data Packs menu, the Open Pack Folder button still create and open a temporary mcworld-<random number> folder on TEMP even with the current version of data-loader installed.

Since this feature of loading packs from a temporary folder isn't really relevant with data-loader around, i suggest the button behavior to be changed, to just open the datapacks folder instead of creating/opening a temporary only. Don't know how much difficult would be that to implement, but it would be just a small "aesthetical" change, no worry to implement that if you have interest too.

Since client/singleplayer doesnt have anything similar to the initial-enabled-packs and initial-disabled-packs options from dedicated server's server.properties file, i suggest implementing a config file only for clients to specify the default list of datapacks to be automatically loaded from datapacks folder, and their order. If possible, also allow the internal ones (bundle and update_1_20 on 1.19.4) to be activated by default (in vanilla they are disabled by default).

Sorry to be annoying again, but a build for 1.20-pre4 is feasible before the official release? I'm already developing a datapack for the future version of my modpack and i really miss your mod to facilitate things.

Also since it seems to be a huge update why not release at least one update for the pre versions, even to get acquainted with the internal changes of the new version?

Again, i apologize if the question sounds annoying, not my intention.

disclaimer, I've been able to use this mod just fine for single player worlds.

data-loader isn't loading data packs when used in a server setting.

I used the file data-loader-1.0.0.jar from the modrinth link https://modrinth.com/mod/dataloader/version/RWYHtoRI .

The bug can be replicated by setting up a fabric 1.18.1 server either on the local dev machine or a hosted server with data-loader in the mods folder.

Don't know if is possible, but if the game detects a datapack is invalid (like with json errors, etc), data loader should give up forcing the load of it and proceed with loading the rest of the packs.

The reason i'm asking this is because i forgot a comma in one of my datapacks without realizing, tried to load the game and it was crashing on the new world screen, without giving much hints of the source of the crash in the logs.

A lot of mods I want to use are back on 1.20.1. Is that supported by any of the versions? It looks like that was skipped; 1.1.3 supports up to 1.20 and 1.1.4 supports 1.20.2+. Do either of those actually support 1.20.1 also?

Unfortunately, different from previous versions, this time Dataloader 1.1..3 crash when loaded on 1.20.2-pre2 (Loader 0.14.22, API 0.88.3) when entering the singleplayer create world screen.

CRASH REPORT

I bet the issue is related to the GUI assets changes Mojang is doing with that version, so maybe this is a quick fix, or not...