codeur / capistrano-sentry Goto Github PK

I recently suggested that some other devs use capistrano-sentry for their project. They had some questions about exactly what values should be provided in config/deploy.rb. I am suggesting some modifications to the docs to make this a little more clear.

I'll write this up and submit a PR.

In the current product I'm working on, we use two different Sentry projects to distinguish between backend and frontend.

We started using the gem, but it currently doesn't allow us to notify releases in multiple projects. I see a closed PR that tried to add this functionality, but it was closed by the author (#10).

Would you want this gem to support multiple projects? If you agree, I'm available to create a PR for it.

Thank you for the great gem 💚

gem version

v0.4.1

error message

  INFO [sentry:validate_config] Validating Sentry notification config
(Backtrace restricted to imported tasks)
cap aborted!
NoMethodError: undefined method `blank?' for #<String:0x00005577f98d6c58>

Tasks: TOP => deploy:starting => sentry:validate_config
(See full trace by running task with --trace)
The deploy has failed with an error: undefined method `blank?' for #<String:0x00005577f98d6c58>

code location

causing

blank? is the method of Ruby on Rails.

https://api.rubyonrails.org/v6.0.3.1/classes/String.html#method-i-blank-3F

It is not in method of ruby's string class.

irb(main):003:0> 'string'.respond_to?(:blank?)
=> false

comment

I'm at work so I created an issue first.
When I find the time, I will create a pull request.

Thanks for your gem.

Command to reproduce the error.

be cap production deploy --dry-run

Errors that I'm getting.

00:00 sentry:validate_config
      [sentry:validate_config] Validating Sentry notification config
fatal: ambiguous argument '^': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
00:01 sentry:notice_deployment
      Notified Sentry of new release: 956e3ea6f4553437f9010bb1e81fdfb3425574ba
      Notified Sentry of new deployment: 956e3ea6f4553437f9010bb1e81fdfb3425574ba-20190813090706

After checking the source code, it's possible this is the line that's causing the error

Testing the command locally, possibly this is the issue?

1. git rev-parse feature/update_sentry_capistrano^ - Ok
2. git rev-parse master^ - Failed.