coders-school / git-checker Goto Github PK

Test of my homework fails because of two issues reported, they are a bugs in my opinion:

➡️ 'main.cpp' created ❌ Failed
I created main.cpp file using 'vim' instead of 'touch' which the most probably was expected here. As I noticed this is not the first issue which reports this problem - is it possible to update the test script to make it more flexible?

➡️ HEAD moved to "Initial commit" ❌ Failed
I moved the HEAD using command 'git rebase -i', the result is exactly the same as in case of 'git reset' which was supposed to be used, however tests did not pass.

Let me know if I need to correct my solution. BR

[PL]„Ale już widziałem zeznanie podatkowe jednego programisty wkomitowane do repozytorium. A modyfikacja historii repo to nie taka prosta sprawa.”
W języku polskim nie powinno zaczynać się zdania od "a" i "ale". Mimo zdaniem "Ale" jest zbędne, a "A" jest w środku zdania, więc powinno być z makiem litery i przed nim powinien być przecinek, a nie kropka.

I really have no idea why in my case it does not pass the test as below

➡️ Pushed to the remote repo ❌ Failed

I had a problem along the way but I think I fixed everything and as a result the repo is as expected.

The fact that the previous tests had something to check proves that the push was successful, so I am reporting this as an issue

link

Once a PR has been sent, changing anything in your own repository does not send another PR to git-checker . Only changing anything in the address.txt file forces another PR update.

In My opinion this is low level priority error, because this is only other idea to solve the excercise.
HEAD moved to Initial commit this error occurs when branch is created by
git checkout -b cs HEAD^ instead of
git checkout -b cs then git reset --hard HEAD^ or similar.
This is only shortcut for replace two line of code to one.

Hi! My homework hasn't passed one test: 'main.cpp' created
I created the file main.cpp by typing code main.cpp in terminal. It runs VSC with opened new file main.cpp. It was just faster for me considering I need to write some code there. In the instructions for the homework it's not said I need to create an empty file main.cpp first, so I think the test should pass. Guess the others could use any editor the same way. Maybe we should remove this part of the test and only check if the repository contains main.cpp?
I suspect if I used touch main.cpp it would pass. Should I correct my solution and rerun the tests?

PS. It's my first issue post on GH, so forgive me if I've done something wrong.

In the GIT homework I got a little bit confused at one point and I would change:
"Zrób push z i na gałąź master"
into "Zrób push z lokalnej gałęzi master na znalną"
The initial description was correct but I think the proposed version is easier to understand.

After doing some operations in VSC I didn't pass some of the tests. I think it should be clearly stated in the beginning of the homework description that all the commands should be typed in via console.