codelytv / typescript-ddd-example Goto Github PK

Hello,

it seems the typeorm version you are using is deprecated

Could you update it to the latest version?

You have this at the CoursePutController.ts#L20:

    try {
      await this.commandBus.dispatch(createCourseCommand);
    } catch (error) {
      if (error instanceof CourseAlreadyExists) {
        res.status(httpStatus.BAD_REQUEST).send(error.message);
      } else {
        res.status(httpStatus.INTERNAL_SERVER_ERROR).json(error);
      }
    }

Right now this works because we are using an InMemoryCommandBus implementation. But, if we change the CommandBus implementation to one where we cannot expect the execution of the code (for example if we store this command in Kafka for later consumption), the implementation of this controller wouldn't work at all (because the use case will never get executed in this request, and it will never throw).

Is this true? Thanks!

Hola amigos, de codely, quiero aprender DDD o arquitectura exgonal, empece aprender typescript, hay un curso de esto?

Tengo un commandBus en el controller y además necesito un commandBus en el aplication service para poder lanzar un caso de uso de otro módulo dentro del mismo context, pero al añadir ese segundo commandBus me salta el error: RangeError: Maximum call stack size exceeded

No estoy muy familiarizado con la inyección de dependencias y no sabría como solucionar este problema de dependencia circular,
¿Hay alguna forma de solucionarlo?

Muchas gracias.

Este error viene dado cuando desde cualquier fichero de ruta se hace el import container from '.. /config/dependency-injection'

/var/www/vhosts/chatastro.com/develop.api.chatdevelop.com/node_modules/node-dependency-injection/dist/lib/Loader/YamlFileLoader.js:73
throw new _ServiceFileNotFoundException"default";
^

Error
at new ServiceFileNotFoundException (/var/www/vhosts/chatastro.com/develop.api.chatdevelop.com/node_modules/node-dependency-injection/dist/lib/Exception/ServiceFileNotFoundException.js:45:19)
at YamlFileLoader.load (/var/www/vhosts/chatastro.com/develop.api.chatdevelop.com/node_modules/node-dependency-injection/dist/lib/Loader/YamlFileLoader.js:73:15)
at Object. (/var/www/vhosts/chatastro.com/develop.api.chatdevelop.com/dist/src/apps/mmc/config/dependency-injection/index.js:7:8)
at Module._compile (internal/modules/cjs/loader.js:1151:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1171:10)
at Module.load (internal/modules/cjs/loader.js:1000:32)
at Function.Module._load (internal/modules/cjs/loader.js:899:14)
at Module.require (internal/modules/cjs/loader.js:1040:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object. (/var/www/vhosts/chatastro.com/develop.api.chatdevelop.com/dist/src/apps/mmc/routes/authRoute.js:6:32) {
name: 'ServiceFileNotFoundException'
}
`

I have a question regarding the responsability of incrementing the total in CousesCounter, Shouldn't this be on domain layer?

like tell the CoursesCounter to increment and let it to deside if this needs to be done or not, sounds to me like a bussines logic, but I could be wrong.

https://github.com/CodelyTV/typescript-ddd-skeleton/blob/8b9775292d60498d79ca39ea95213cda9db6cf93/src/Contexts/Mooc/CoursesCounter/application/Increment/CoursesCounterIncrementer.ts#L13-L14

Is this someth

Hi, good job with the project. I believe that domain entities should have a private constructor. Right now we are able to create instances from those classes by static methods which are correct but we are also able to do it by calling new - in that way domain events would not be published.

Hi,

How can put a middleware in a route? I tried several times, but I have not been able to achieve it.

Thanks !

What is the reason for not using absolute imports?.

I ask, because I do not know if using this functionality has counterproductions in terms of performances or some other.

Hola chicos,

Podria ser que estos awaits no fueran necesarios y se quedara pillado ahi?

Saludos.

Coupling the infrastructure layer to the domain layer.

Should be great have the template option for this project.

Thanks !