codebradley / python-uptimerobot Goto Github PK

According to https://uptimerobot.com/apiv1 the version 1 of the API was retired on 1 Jan 2017.

alert_contact.py

from future import absolute_import, division, print_function, unicode_literals

from termcolor import colored

class AlertContact(object):
class Type:
SMS = 1
EMAIL = 2
TWITTER = 3
BOXCAR = 4
PUSHBULLET = 6
WEBHOOK = 5

TYPES = {
    Type.SMS: "sms",
    Type.EMAIL: "email",
    Type.TWITTER: "twitter",
    Type.BOXCAR: "boxcar",
    Type.PUSHBULLET: "pushbullet",
    Type.WEBHOOK: "webhook",
}

https://github.com/CodeBradley/python-uptimerobot/blob/master/uptimerobot/uptimerobot.py#L228

I'm extending your code to include some additional API functions and this method was returning None. The problem is that if UptimeRobot returns stat:'fail' then the method doesn't return. This is because stat does exist, but the value is not 'ok'. I believe I fixed this issue by updating the code to:

def requestApi(self, url):
        response = urllib_request.urlopen(url)
        content = response.read().decode('utf-8')
        jContent = json.loads(content)
        if jContent.get('stat'):
            stat = jContent.get('stat')
            if stat == "ok":
                return True, jContent
        return False, jContent

To allow easy install for end users, the package should be listed on PyPi.

Some errors occur on import (Python3.4):

from uptimerobot.uptimerobot import UptimeRobot
  File "~/Code/src/uptimerobot/uptimerobot/uptimerobot.py", line 103
    except Exception, e:
                    ^
SyntaxError: invalid syntax

Hi @CodeBradley

I'm happy that you continue the development of python-uptimerobot and maintain the package.
We should transfer the project on the Python Package Index as well - otherwise you cannot push new releases to the PyPI. Could you please give me your username? Thanks.