code4romania / civichq-client Goto Github PK

Exista 2 servicii care apeleaza acelasi endpoint: category.service.ts in AddApp si in HomePage.
Tb sa ramana unul singur.

GetCategories nu merge cand endpointul e securizat in AddApp.
In home nu este nicio problema.

Stale branches to be investigated and merged to develop branch or removed if no longer needed.

https://github.com/code4romania/civichq-client/branches/stale

Add cookie policy for Centru Civic website.

Depends on #55

Best practices

• codebase language should be English
• we 💕 unit tests

Add a header with text and graphic that leads to the about section in order to explain what the app is about

Draft text for terms and conditions for Centru Civic

Add a section in the admin dashboard to allow the admin to mark an app dead or active

The section could be included in the edit app form for the admin, which looks like the add app form http://www.centrucivic.ro/#/add-app or in the app card that looks like:

When I follow the instructions from the readme, the project will not compile. First there are a couple of warnings during npm install and npm start fails during webpack initialization. I have tried to upgrade components, even rewrote some lines as f.i. the select module in later versions is in ng2-select/select/ instead of ng2-select/components/select/ but this does not work. I am using atom.io as editor, and am running npm from the commandline on linux. node v7.4.0 npm v4.1.2, os: 4.9.6-1-ARCH #1 SMP PREEMPT Thu Jan 26 09:22:26 CET 2017 x86_64 GNU/Linux

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN [email protected] requires a peer of rxjs@^5.0.0 but none was installed.
npm WARN [email protected] requires a peer of @angular/core@^2.4.1 but none was installed.
npm WARN [email protected] requires a peer of @angular/common@^2.3.0 but none was installed.
npm WARN [email protected] requires a peer of @angular/core@^2.3.0 but none was installed.
npm WARN [email protected] requires a peer of @angular/common@^2.3.0 but none was installed.
npm WARN [email protected] requires a peer of @angular/compiler@^2.3.0 but none was installed.
npm WARN [email protected] requires a peer of @angular/core@^2.3.0 but none was installed.
npm WARN [email protected] requires a peer of @angular/forms@^2.3.0 but none was installed.
npm WARN [email protected] No repository field.

And then, npm start results in:

ERROR in ./src/main.ts
(7,28): error TS2307: Cannot find module 'ng2-select/components/select/common'.

ERROR in ./src/main.ts
(8,29): error TS2307: Cannot find module 'ng2-select/components/select/select-pipes'.

ERROR in ./src/app/pages/HomePage/home.module.ts
(12,32): error TS2307: Cannot find module 'ng2-bootstrap/components/carousel'.

ERROR in ./src/main.ts
Module not found: Error: Cannot resolve module 'ng2-select/components/select/common' in /home/miblon/NetBeansProjects/civichq-client/src
 @ ./src/main.ts 6:15-61

ERROR in ./src/main.ts
Module not found: Error: Cannot resolve module 'ng2-select/components/select/select-pipes' in /home/miblon/NetBeansProjects/civichq-client/src
 @ ./src/main.ts 7:21-73

ERROR in ./src/app/pages/HomePage/home.module.ts
Module not found: Error: Cannot resolve module 'ng2-bootstrap/components/carousel' in /home/miblon/NetBeansProjects/civichq-client/src/app/pages/HomePage
 @ ./src/app/pages/HomePage/home.module.ts 16:17-61
Child html-webpack-plugin for "index.html":
    chunk    {0} index.html 1.64 kB [rendered]
        [0] ./~/html-webpack-plugin/lib/loader.js!./src/index.html 1.64 kB {0} [built]
webpack: Failed to compile.

@octaviandavid e posibil sa fie din AWS?

Elementele din header (navbar collapsed, valoarea campului search) nu isi reseteaza starea cand navighezi de la o pagina la alta.

If an app has many hashtags the approve app toggle is displaying incorrectly. See below:

Add a new content section for technologies in the app page

In API ajung ok, dar in baza de date se pierd.

Add a donate button for Code for Romania just like in all other apps. See https://monitorizarevot.ro/ for example.

Best practices

• codebase language should be English

• add the possibility to delete an app from main admin panel
• call correct endpoint for deleting an app: related to #code4romania/civichq-api#74

Best practices

• codebase language should be English
• we 💕 unit tests

Urmeaza sa pun un spinner in div-ul care tine pozele (padding bottom hack), as vrea ca acestea sa se incarce async cu un fade in de 100ms, standard preload behavior.

Add a new content section for technologies in the app details page

The info about the technologies field should be returned by the API code4romania/civichq-api#81

Best practices

• codebase language should be English
• we 💕 unit tests

getToken() is in app.service.ts

Problems:

• password is shown in clear text
• unclear need for this method - seems to be used when the admin tries to approve an app

Add Terms and conditions for Centru Civic website.

Depends on #57

Draft text for cookie policy for Centru Civic

Campul de selectie a datei crearii aplicatiei trebuie sa fie un date picker, use https://www.npmjs.com/package/ng2-datepicker

suggestion: https://github.com/lorenwest/node-config

1. /#/login -> /#/approve-app
2. approve 2-3-4 apps una dupa alta
3. doar primul app selectat se aproba, requesturile se fac

Slack or e-mail for credentails.

Momentan este validata doar prezenta campurilor obligatorii nu si tip-ul datelor din campurile obligatorii si restul campurilor.

• unde se cere un URL pot pune orice text, URL-ul introdus trebuie sa fie in format http://cea.ceva/altceva
• numarul de telefon: +40123456214

La descriere se transmite data creatiei; descrierea nu e salvata.

Add a header with text and graphic that leads to the about section in order to explain what the app is about

Depends on wireframe task #64

Best practices

• codebase language should be English
• we 💕 unit tests

/#/123/app-name

Add ”an app by Code for Romania” in the header section below the logo. See https://votdiaspora.ro/#/home for an example.

Best practices

• codebase language should be English

Cand se incarca date intre pagini sau cand se trimite un app as vrea sa nu vad un ecran gri ci un spinner care imi indica ca ceva se intampla (pot sa nu fiu pe o conexiune foarte buna).

Pe IE11 textul din form-search este deplasat. Un click in input si in afara lui il repozitioneaza corect.

Add a Technologies used field in the registration form and edit app form from admin.
The field should be mandatory.

For filling in this field, the user should be able to select all related technologies form a list retrieved from the API - related to code4romania/civichq-api#80
The info filled in by #the user should be sent to the API on the add app and edit app calls. code4romania/civichq-api#81

Check out what was already implemented on this at HackDay#1 and continue from there 😄 #80

Adding technologies field should look similar to adding topics on github repos, colored cards:

Best practices

• codebase language should be English
• we 💕 unit tests

E nevoie de content aici. cc Olivia

Aplicatia nu revine la home page din pagina individuala a unui app (cred ca este ceva legat de back, nu neaparat de pagina de app).

1. /#/home
2. click pe orice app
3. back din butonul/trackpad/backspace

Add a section in the admin dashboard to allow the admin to mark an app dead or active - to be added in the edit app form.

Suggestion: a small toggle used to mark active / not active status for apps.

Depends on wireframe task #59
Depends on API task code4romania/civichq-api#82

Best practices

• codebase language should be English
• we 💕 unit tests

Add a FB icon in the main menu to direct people to the apps Facebook page

Best practices

• codebase language should be English