Comments (13)
odd I thought we were linking for making sure all github links used https.
from core.
Nah, the goal is to not fail on private spec repos, see #83. The GitHub check only verifies that you don't use http.
from core.
https://github.com/CocoaPods/Core/blob/master/spec/specification/linter_spec.rb#L266-L276
I don't suppose there is a method to check if the repo is the master? Maybe a kludgey hack would be to check if the lint is running on Travis LOCALLY in the master repo, but that definitely makes me feel uncormfortable enough that it is not the correct solution
from core.
It is already failing on Travis, though, with a somewhat understandable error message.
Personally, I can only see the goal to have people realise this before making a PR, for that the lint commands would need a switch to specify they are for the master repo or one to specify that they are for a private one.
from core.
I'm sorry yes that was a mistake on my part - I believe the issue was I linted the file locally and it passed which confused me when providing support in Specs.
It's definitely something I can manually look out for now, but it could be an opportunity to clear things up when locally linting.
from core.
@neonichu when trunk will be introduced that full check performed by Travis will be removed (because waiting for the pull-request made Trunk too much complex... if I'm correct... @alloy ?). So @squarefrog makes sense in my opinion.
We could pass to the Validator whether we are submitting to the master repo and in that case run additional checks.
from core.
Ah, I see.
I would suggest assuming the master repo by default and passing something to the Validator if some other spec repo is used. That way it would do the right thing for inexperienced users.
from core.
👍
from core.
because waiting for the pull-request made Trunk too much complex... if I'm correct...
@irrationalfab Aye, it adds complexity while not educating spec authors, as some use it as a way to get their specs in order instead of trying in a real app etc.
from core.
I agree with @neonichu.
At some point it might be nice if you could have a default options config inside a spec repo. That way private spec repos could indicate what type of linting they want etc.
from core.
At some point it might be nice if you could have a default options config inside a spec repo. That way private spec repos could indicate what type of linting they want etc.
Is there any benefit in maintaining this?
from core.
The idea is that you then no longer have to specify certain options for certain repos. However, this only makes sense if we really really really need options at all.
from core.
I think that having a higher set of checks for just the master repo is simpler and sufficient for the moment.
from core.
Related Issues (20)
- [Discussion] Improve checksum for git branch based spec HOT 1
- Spelling mistake: perfomed HOT 2
- CDNSource: delete a podspec if corruption is detected HOT 2
- pod spec lint warns about 'readme' and 'changelog' attributes HOT 1
- Are you using a global gitignore to ignore the vendor directory? HOT 1
- CDN_source does not handle http302 response codes
- Please I need clear explanation on how can I change my cocoapods of version 1.9.3 to 1.10.1 version. I have researched online and done update, uninstall and reinstall, yet it didn't work. HOT 2
- Latest version 1.10.1 has CVE-2020-8165 alert HOT 1
- can it support the version 6.0 for activesupport ? HOT 1
- pod install - error message "Couldn't determine repo name for URL ..." on private repo via SSH HOT 10
- Error with pod install: userinfo not supported. [RFC3986] HOT 9
- if this is a bug or Comment error in the class Pod::Podfile::TargetDefinition HOT 3
- [Discussion] Is it possible to remove "PODFILE CHECKSUM" from the lock files? HOT 4
- [Bug] Dependencies of Target B Linking to Target A in a Two Target Project HOT 1
- Documentation Typo: "will be ran" -> "will be run"
- Specification module name HOT 1
- Missing spec repos on Podfile.lock HOT 2
- Version Comparison Issue with Mixed Numeric and String Prerelease Segments HOT 1
- Exception when using partial / third party CDN sources HOT 18
- In
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.