Coder Social home page Coder Social logo

Comments (10)

dnkoutso avatar dnkoutso commented on August 18, 2024

cc @igor-makarov maybe related to some Core changes?

from core.

dnkoutso avatar dnkoutso commented on August 18, 2024

Most likely related to #681

from core.

dnkoutso avatar dnkoutso commented on August 18, 2024

@glauberl-ciandt if you can expand to fix the regex in #681 with a test it will be very easy to ship 1.11.1 for us.

Sorry for this regression.

from core.

glauberl-ciandt avatar glauberl-ciandt commented on August 18, 2024

@glauberl-ciandt if you can expand to fix the regex in CocoaPods/Core#681 with a test it will be very easy to ship 1.11.1 for us.

Sorry for this regression.

Done. I updated the error message using aaa's for a-z pattern and the rest remained the same.

Let me know if you need further information.

from core.

dnkoutso avatar dnkoutso commented on August 18, 2024

no need! Some help to open the PR if you want to fix it would be great :)

from core.

glauberl-ciandt avatar glauberl-ciandt commented on August 18, 2024

no need! Some help to open the PR if you want to fix it would be great :)

I'll do my best. First time opening a PR to CocoaPods repo! Let's see how it goes.

Just to confirm: the regex is what needs to be fixed, right? Or needs further investigation?

from core.

dnkoutso avatar dnkoutso commented on August 18, 2024

I am fairly certain its the regex. It will be a PR on this repo https://github.com/CocoaPods/Core

See this PR #681 of the files to change.

Add a test first and run bundle exec bacon <path_to_file_spec.rb> to run and see it failing. Then update the regex and re-run to make it pass.

from core.

dnkoutso avatar dnkoutso commented on August 18, 2024

@glauberl-ciandt I put a PR up #703 will wait for some review/feedback to land it.

from core.

dnkoutso avatar dnkoutso commented on August 18, 2024

fixed with #703

from core.

glauberlima avatar glauberlima commented on August 18, 2024

Cool! Thanks!

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.