After launching an external method stops working about masshortcut

[shpakovski]

Hi Cris, thank you for the problem report and the clear sample project. Indeed MASShortcut is resetting the hotkey and its block while NSOutlineView is being loaded and changing preferences. I will think how to improve the component to avoid this. Till then, please consider a workaround like loading NIB in the next run loop out of the block. Sorry for inconvenience :)

[synapse]

Workaround:
move all your code from the block to a method and run the method from within the block like this:

[self performSelectorOnMainThread:@selector(yourMethod) withObject:nil waitUntilDone:NO]; //if UI is involved
[self performSelectorInBackground:@selector(yourMethod) withObject:someObject]; //if no UI involved

[DenVog]

Thank you for posting this! I was running into this same issue, and was beating my head against the wall trying to figure out what I was doing wrong. This got it!

[lmirosevic]

Just want to second this issue. The workaround posted by synapse does work but it would be nice to see this fixed some time.

[holgersindbaek]

I think I have the same problem. It is really strange.

I call a method each time the user pressed their shortcut key, which hides and shows the current window. Pressing the shortcut works once or twice, but then it doesn't work anymore.

I've pinpointed the exact line where things go wrong and it is this one:

[[NSUserDefaults standardUserDefaults] setInteger:newNumber forKey:@"timesDisplayed"];

I have absolutely no clue why this should screw up the shortcut, but it does. Now I've put that line into a method and I'm calling that method with this:

[self performSelectorInBackground:@selector(timesDisplayed) withObject:nil];

So now the shortcut works 12-17 times before it breaks. Would be great if someone could take a look at this, because that's a major downer :-(.

Awesome library besides that.

[shpakovski]

@holgersindbaek The problem is with how the MASShortcut component handles changes in user defaults, I will investigate into this as soon as I have time. Sorry for inconvenience guys.

[holgersindbaek]

Sounds great. Looking forward to it!

It's a great little library. Gonna use it much more in the future.

Holger Sindbaek
Holgersindbaek.com (http://Holgersindbaek.com)

Co-founder
Uninkd.com (http://Uninkd.com)
Meer.li (http://Meer.li)

On Tuesday, April 2, 2013 at 6:06 AM, Vadim Shpakovski wrote:

@holgersindbaek (https://github.com/holgersindbaek) The problem is with how the MASShortcut component handles changes in user defaults, I will investigate into this as soon as I have time. Sorry for inconvenience guys.

—
Reply to this email directly or view it on GitHub (#14 (comment)).

[keith]

+1 on this issue, my user defaults change an unrelated key and after a time or two the shortcut is unregistered via this method

[shpakovski]

Guys, I made some changes suggested by @Keithbsmiley, so could you please try the latest commits? Does it help? Thanks in advance!

[keith]

This does not seem to remove the observer from the previous shortcut after changing it

[shpakovski]

Oops, looking into this…

[shpakovski]

Done, please try again. Sorry for inconvenience!

[keith]

This seems to fix all the issues I experienced 🍻

[shpakovski]

Wohoo, thanks all for your help!

[keith]

Thanks for the great tool!