coblox / bitcoinrpc-rust-client Goto Github PK

The following code is obsolete and can be removed:

https://github.com/coblox/bitcoinrpc_rust_client/blob/bd2c506ec5ad5fc68594fc811a50c1d0368cf03c/src/types/address.rs#L88-L97

Instead, conversion with From should be used.

At the moment, the documentation is basically non-existent. We should add rust-docs comments to the source code and link the README with the Cargo.toml file so that it is rendered on crates.io.

Version 0.17 added some breaking changes, we should account for that in the API and adapt.

If rust-bitcoin/rust-bitcoin#168 gets merged, we should be able to get rid of our TransactionId new type struct and use Sha256dHash directly as it provides all the necessary functionality, including serde support.

As per #44, contribute to rust-bitcoin/rust-bitcoincore-rpc:

• Add retry on -32 rust-bitcoin/rust-bitcoincore-rpc#8
• Add test-containers

DoD:

• Pull request for changes are integrated
• README update to deprecate this repo in favor of rust-bitcoin's

The HTTPError from jsonrpc should be re-exported, otherwise it is cumbersome to implement the BitcoinRpcApi trait because one has to pull in reqwest::Error manually.

Look at https://github.com/rust-bitcoin/rust-bitcoincore-rpc

DoD:

• list missing features that'd we need to implement in rust-bitcoincore-rpc
• evaluate how much work it would be to start using it

The fields on most payloads that we deserialize to should most likely be public as it is just inconvenient to not being able to access them from the outside.

• Transaction
• Detail
• VerboseRawTransaction
• ScriptSig
• NewTransactionInput
• TransactionOutputDetail
• SigningError
• SigningResult
• FundingResult
• MultiSigAddress
• AddressValidationResult
• Block
• SoftFork
• Reject
• Bip9SoftFork
• Bip9SoftForkDetails
• BlockchainInfo
• RedeemScript
• DecodedScript