coastalwhite / manger Goto Github PK

It would really awesome to add a Trim<T> type which removes any surrounding Whitespace. This could also come with TrimLeft<T> and TrimRight<T> which would only trim on the left or the right side, respectively.

These types should be in the manger::common module most probably.

There should something to consume arbitrary, such as encased strings.

The preferred syntax for this should be something like this, but maybe there is a better syntax for this:

use manger::consume_struct;

struct UntilClosingParenthese(String);
consume_struct!(UntilClosingParenthese => [ value: &str { @until ')' }; (value) ]);

Right now, interloping Whitespace or OneOrMore<Whitespace> everywhere is kind of bloating a lot of code. It would be nicer if we had something like this:

use manger::consume_struct;

struct Sum(i32);
consume_struct!(
  Sum => (@i[OneOrMore<Whitespace>])[
    left: i32,
    > '+',
    right: i32;
    (left + right)
  ]
);

The macros consume_struct and consume_enum should be turned into procedural macro's.

This will allow for more features later on and the reuse of code.

The ConsumeError now has a couple of problems.

First of all, there is always a heap allocation necessary when any occurs anywhere even if it isn't actually gonna cause the consume to fail. This stifles performance.

Secondly, errors are hard to grasp. There are a lot of errors returned when enums or Either is used. Which makes it very difficult. This makes errors also really difficult to track down.

I would hope a solution to this problem solves both these problems. This would probably also reduces some bloat in the code.