cnhzlt / s2-geometry-library Goto Github PK

What steps will reproduce the problem?
1. N/A

What is the expected output? What do you see instead?
This is a very useful library and it is unfortunate that it has had no updates 
in 4+ years. I do understand that not all software gets continued maintenance, 
and that no good deed goes unpunished, but I would appreciate a clear statement 
about whether there is any intention of fixing issues in this library, or 
whether pulls/patches would be accepted, or whether the project is officially 
abandoned. 

A related question: Will this project be exported to github under the google 
organization ahead of the upcoming decommissioning of Google Code? 

What version of the product are you using? On what operating system?
Latest rev, many platforms

Please provide any additional information below.

What steps will reproduce the problem?
1. Open the makefile
2. look at /home/tudorh/usr at the top.

Documentation page should be added to this site. At least linking to this: 
https://docs.google.com/presentation/d/1Hl4KapfAENAOf4gv-pSngKwvS_jwNVHRPZTTDzXX
n6Q/edit#slide=id.i0

What steps will reproduce the problem?
1. try to build the pywraps2 python module

What is the expected output? What do you see instead?

Expected is that there are a target in the Makefile that produces it.

There are no such target.

vector_output_helper is missing.

What version of the product are you using? On what operating system?

latest'n'greatest, from hg, on ubuntu 13.10

Please provide any additional information below.

managed to find 
http://or-tools.googlecode.com/svn/trunk/src/base/python-swig.cc and glue 
togeather something that almost works.

some trivial misspellings

What steps will reproduce the problem?
1. Add the following test to s2polygonbuilder_test.cc:

TEST(S2PolygonBuilder, Basic) {
  std::vector<uint64> cell_ids({1152921504606846976ULL,   
                                3458764513820540928ULL,
                                5764607523034234880ULL,  
                                8070450532247928832ULL,
                                10376293541461622784ULL, 
                                12682136550675316736ULL});
  S2PolygonBuilder builder(S2PolygonBuilderOptions::DIRECTED_XOR());
  for (uint64 val : cell_ids) {
    S2Loop cell_loop{S2Cell(S2CellId(val))};
    builder.AddLoop(&cell_loop);
  }
  S2Polygon polygon;
  ASSERT_TRUE(builder.AssemblePolygon(&polygon, NULL));
  ASSERT_GT(polygon.num_loops(), 0);   // <- fails here
}

The test fails though at it should pass since those s2cells have boundary.
it seems that the builder does not handle properly the adding of edges.

Compilation fails on recent versions of MacOS.

Multiple sources of problems:
-DOS_MACOSX missing in Makefile
- Usage of lots of nonstandard include files:
  * base/port.h:#include <byteswap.h>
  * base/stl_decl_macosx.h:    
    #include <bits/stl_tempbuf.h>
    #include <ext/functional>
    #include <ext/hash_fun.h>
    #include <ext/hashtable.h>

I'm using the current version of s2-geometry-library.
Will be happy to help, owners/admins please let be in touch if interested.

OS and compiler:
$ uname -a
Darwin gwesp 13.4.0 Darwin Kernel Version 13.4.0: Sun Aug 17 19:50:11 PDT 2014; 
root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64

$ g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr 
--with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
Target: x86_64-apple-darwin13.4.0
Thread model: posix