cmoulton / grokswiftrest_v1.2 Goto Github PK

To fix in next edition

In the landscape for iPad & iPhone 6Plus layout, every time I clicked on a cell of some of the data, it segues to the detailVC on the left side, but the right side where the original detailVC remains empty.

Will be WIP until GM (probably early fall)

Like so:

class func fetchTodos(completionHandler: (Result<[Todo], NSError>) -> Void) {
    let todosEndpoint: String = "http://jsonplaceholder.typicode.com/todos/"
    Alamofire.request(.GET, todosEndpoint)
      .responseJSON { response in
        // check for errors, tell caller if needed
        guard response.result.error == nil else {
          completionHandler(.Failure(response.result.error!))
          return
        }

        // make sure we got data & it's valid JSON
        guard let value = response.result.value else {
          let failureReason = "Could not get or serialize JSON for Todos"
          let error = Error.errorWithCode(.JSONSerializationFailed, failureReason: failureReason)
          completionHandler(.Failure(error))
          return
        }

        // Make sure the JSON is an array, like we expect (and not a dictioanry)
        guard let jsonTodosArray = value as? [[String: AnyObject]] else {
          let failureReason = "Todos not parsed as expected array"
          let error = Error.errorWithCode(.JSONSerializationFailed, failureReason: failureReason)
          completionHandler(.Failure(error))
          return
        }

        // Turn the JSON array into an array of Swift objects
        // assumes we have a Todo class with an initializer that takes a jsonArray
        let todosArray = jsonTodosArray.flatMap { Todo(jsonArray: $0) }

        // hand the array of Todos back to the caller
        completionHandler(.Success(todosArray))
      }
  }

JSON parsing is well encapsulated and the object model in the app matches the data source fairly well, so there's not a ton of value to SwiftyJSON, unless I start using the error checking more.

this part of the GitHubAPIManager seems to error if there is no data already in the keychain:

get { // try to load from keychain Locksmith.loadDataForUserAccount("github") let dictionary = Locksmith.loadDataForUserAccount("github") return dictionary?["token"] as? String }

the Locksmith function performSecureStorageAction throws an error - NotFound.

however Locksmith.loadDataForUserAccount doesn't itself throw errors, so how to tell if it already exists ? Apologies if this is really a Locksmith problem..

Q> I keep getting this error on the console - Error Domain=com.alamofire.error Code=-6003 "Response status code was unacceptable: 404" UserInfo={StatusCode=404, NSLocalizedFailureReason=Response status code was unacceptable: 404} when the data is loaded to the table.
Tried to search, but not sure how to fix it.

A> There’s a generic log statement in the code that checks if a gist is starred. But the correct response from the API in that case is a 404: https://developer.github.com/v3/gists/#check-if-a-gist-is-starred
I should remove the log statement but I wanted it there in case of generic errors. It should be improved so it ignores 404’s but logs other errors for that call.

// Warning once only: Detected a case where constraints ambiguously suggest a height of zero for a tableview cell's content view. We're considering the collapse unintentional and using standard height instead.