cmoa / collection Goto Github PK

View Code? Open in Web Editor NEW

103.0 103.0 22.0 106.54 MB

The collection data of the Carnegie Museum of Art in Pittsburgh, Pennsylvania

Home Page: https://collection.cmoa.org

License: Creative Commons Zero v1.0 Universal

collection's People

Contributors

Stargazers

Watchers

collection's Issues

`item_width` repeated in README

Minor text change ;-)

Missing DOI

We reference a DOI, but we haven't actually generated one yet.

URLs in JSON files lead to 404 errors

I notice that many if not all the URLs in your JSON files lead to 404 Not Found errors.

example:

in file: https://github.com/cmoa/collection/blob/master/cmoa/0018b42c-b408-4070-94a7-843288cceb9a.json
Line 17:
"web_url": "http://collection.cmoa.org/CollectionDetail.aspx?item=1023910",

web_url here leads to a 404 Not Found error

Line 17:
"image_url": "http://collection.cmoa.org/CollectionImage.aspx?irn=72723&size=Medium"

image_url here leads to a 404 Not Found error

but this link works:

https://collection.cmoa.org/objects/0018b42c-b408-4070-94a7-843288cceb9a

Perhaps all the URLs need updating?

Missing columns + incorrect date value (Good Tables report)

I forked this repository and slightly edited the datapackage.json to remove the schema references which now work differently (http://specs.frictionlessdata.io/tabular-data-resource/). Unfortunately, this involves literally copying the schema across two different resources. This is necessary to use the tools until they catch up to v1 of the specs and support JSON Pointers.

After that, I ran goodtables datapackage datapackage.json (https://github.com/frictionlessdata/goodtables-py) which will test the first 1000 rows. It looks like the [missing-value] errors result from having too few columns (commas) for these rows. It looks like several columns look something like below:

a,b,c
1,2
3,4
5,6

as opposed to:

a,b,c
1,2,
3,4,
5,6,

Finally, on row 991, there is an incorrectly formatted date: -0001-01-03.

There may be more errors like this. This is only for the first 1000 rows.

$ goodtables datapackage datapackage.json

[6,29] [missing-value] Row 6 has a missing value in column 29
[7,29] [missing-value] Row 7 has a missing value in column 29
[8,29] [missing-value] Row 8 has a missing value in column 29
[9,29] [missing-value] Row 9 has a missing value in column 29
[10,29] [missing-value] Row 10 has a missing value in column 29
[11,29] [missing-value] Row 11 has a missing value in column 29
[12,29] [missing-value] Row 12 has a missing value in column 29
[13,29] [missing-value] Row 13 has a missing value in column 29
[14,29] [missing-value] Row 14 has a missing value in column 29
[15,29] [missing-value] Row 15 has a missing value in column 29
[33,29] [missing-value] Row 33 has a missing value in column 29
[150,29] [missing-value] Row 150 has a missing value in column 29
[165,29] [missing-value] Row 165 has a missing value in column 29
[339,29] [missing-value] Row 339 has a missing value in column 29
[356,29] [missing-value] Row 356 has a missing value in column 29
[358,29] [missing-value] Row 358 has a missing value in column 29
[366,29] [missing-value] Row 366 has a missing value in column 29
[370,29] [missing-value] Row 370 has a missing value in column 29
[372,29] [missing-value] Row 372 has a missing value in column 29
[373,29] [missing-value] Row 373 has a missing value in column 29
[405,29] [missing-value] Row 405 has a missing value in column 29
[412,29] [missing-value] Row 412 has a missing value in column 29
[413,29] [missing-value] Row 413 has a missing value in column 29
[414,29] [missing-value] Row 414 has a missing value in column 29
[415,29] [missing-value] Row 415 has a missing value in column 29
[416,29] [missing-value] Row 416 has a missing value in column 29
[417,29] [missing-value] Row 417 has a missing value in column 29
[418,29] [missing-value] Row 418 has a missing value in column 29
[422,29] [missing-value] Row 422 has a missing value in column 29
[424,29] [missing-value] Row 424 has a missing value in column 29
[441,29] [missing-value] Row 441 has a missing value in column 29
[443,29] [missing-value] Row 443 has a missing value in column 29
[444,29] [missing-value] Row 444 has a missing value in column 29
[445,29] [missing-value] Row 445 has a missing value in column 29
[448,29] [missing-value] Row 448 has a missing value in column 29
[458,29] [missing-value] Row 458 has a missing value in column 29
[459,29] [missing-value] Row 459 has a missing value in column 29
[479,29] [missing-value] Row 479 has a missing value in column 29
[480,29] [missing-value] Row 480 has a missing value in column 29
[481,29] [missing-value] Row 481 has a missing value in column 29
[482,29] [missing-value] Row 482 has a missing value in column 29
[483,29] [missing-value] Row 483 has a missing value in column 29
[484,29] [missing-value] Row 484 has a missing value in column 29
[488,29] [missing-value] Row 488 has a missing value in column 29
[492,29] [missing-value] Row 492 has a missing value in column 29
[503,29] [missing-value] Row 503 has a missing value in column 29
[527,29] [missing-value] Row 527 has a missing value in column 29
[529,29] [missing-value] Row 529 has a missing value in column 29
[546,29] [missing-value] Row 546 has a missing value in column 29
[550,29] [missing-value] Row 550 has a missing value in column 29
[552,29] [missing-value] Row 552 has a missing value in column 29
[557,29] [missing-value] Row 557 has a missing value in column 29
[565,29] [missing-value] Row 565 has a missing value in column 29
[572,29] [missing-value] Row 572 has a missing value in column 29
[574,29] [missing-value] Row 574 has a missing value in column 29
[644,29] [missing-value] Row 644 has a missing value in column 29
[645,29] [missing-value] Row 645 has a missing value in column 29
[648,29] [missing-value] Row 648 has a missing value in column 29
[652,29] [missing-value] Row 652 has a missing value in column 29
[655,29] [missing-value] Row 655 has a missing value in column 29
[661,29] [missing-value] Row 661 has a missing value in column 29
[667,29] [missing-value] Row 667 has a missing value in column 29
[670,29] [missing-value] Row 670 has a missing value in column 29
[671,29] [missing-value] Row 671 has a missing value in column 29
[729,29] [missing-value] Row 729 has a missing value in column 29
[730,29] [missing-value] Row 730 has a missing value in column 29
[754,29] [missing-value] Row 754 has a missing value in column 29
[764,29] [missing-value] Row 764 has a missing value in column 29
[766,29] [missing-value] Row 766 has a missing value in column 29
[767,29] [missing-value] Row 767 has a missing value in column 29
[769,29] [missing-value] Row 769 has a missing value in column 29
[773,29] [missing-value] Row 773 has a missing value in column 29
[776,29] [missing-value] Row 776 has a missing value in column 29
[786,29] [missing-value] Row 786 has a missing value in column 29
[837,29] [missing-value] Row 837 has a missing value in column 29
[841,29] [missing-value] Row 841 has a missing value in column 29
[842,29] [missing-value] Row 842 has a missing value in column 29
[844,29] [missing-value] Row 844 has a missing value in column 29
[884,29] [missing-value] Row 884 has a missing value in column 29
[891,29] [missing-value] Row 891 has a missing value in column 29
[892,29] [missing-value] Row 892 has a missing value in column 29
[893,29] [missing-value] Row 893 has a missing value in column 29
[898,29] [missing-value] Row 898 has a missing value in column 29
[899,29] [missing-value] Row 899 has a missing value in column 29
[904,29] [missing-value] Row 904 has a missing value in column 29
[905,29] [missing-value] Row 905 has a missing value in column 29
[918,29] [missing-value] Row 918 has a missing value in column 29
[951,29] [missing-value] Row 951 has a missing value in column 29
[957,29] [missing-value] Row 957 has a missing value in column 29
[960,29] [missing-value] Row 960 has a missing value in column 29
[961,29] [missing-value] Row 961 has a missing value in column 29
[962,29] [missing-value] Row 962 has a missing value in column 29
[965,29] [missing-value] Row 965 has a missing value in column 29
[968,29] [missing-value] Row 968 has a missing value in column 29
[969,29] [missing-value] Row 969 has a missing value in column 29
[973,29] [missing-value] Row 973 has a missing value in column 29
[974,29] [missing-value] Row 974 has a missing value in column 29
[986,29] [missing-value] Row 986 has a missing value in column 29
[987,29] [missing-value] Row 987 has a missing value in column 29
[988,29] [missing-value] Row 988 has a missing value in column 29
[989,29] [missing-value] Row 989 has a missing value in column 29
[991,3] [non-castable-value] Row 991 has non castable value -0001-01-03 in column 3 (type: date, format: default)
[1000,29] [missing-value] Row 1000 has a missing value in column 29

Update datapackage.json to latest specifications

http://specs.frictionlessdata.io/

Move enum and required fields to within constraints object
Transform license field (string) to licenses field (array)
Update schema reference ("cmoa-schema") to JSON Pointer (current tools don't support atm but will soon)

Specify total number of objects

I'd add the expected number of objects to the README (27371 by my count), since #1 means someone might naively run wc -l cmoa.csv and get 30128 and get confused.

Roles are not properly linked to the correct name

If the first role is NULL, the roles are not assigned to the correct party.

\n within fields

It's probably worth warning the user that they will find \n interspersed in the provenance fields, as this can (annoyingly) choke some CSV parsers. Do line breaks occur in any other fields?

Contributor policies

This question may be part of a bigger discussion, but what would a CONTRIBUTOR file look like for this repo, given that (like all the museum datasets out there, I'd wager) it is a generated extract of an upstream CMS?

This would be relevant particularly for PRs/issues that address data content. Over at the @tategallery they have accepted PRs that have addressed typos in the original data, presumably following some internal process for integrating those changes upstream into their CMS. @MuseumofModernArt doesn't have any PRs quite like that, but there are a few issues where users have pointed out typos, and maintainers note that the fixes will be made to the source CMS and reflected downstream in the next repo update. Depending on the internal workflow that you settle on, it might be useful to let contributors know that issues, rather than PRs, will be welcomed; or that PRs are welcome but will not be accepted into the repo, instead being addressed in the next content update, etc.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.