cmiles74 / clojure-hl7-messaging-2-parser Goto Github PK

I cloned your repo and did a build however I am unable to parse an HL7 message without getting a run-time exception stating "End of data reached while reading text." I then switched to generating an HL7 message using your parser and then serializing that to see what a properly serialized message should look like. I still didn't see any differences so I wrote a snippet that generated an HL7 message, serialized it, and then parsed it and the parsing fails with the same run-time exception. Please advise on how to properly parse an HL7 message or if this uncovered a bug.

(def my-delimiters (struct-map parser/delimiters-struct :field 124
:component 94 :subcomponent 38 :repeating 126 :escape 92))

(def generated-message (create-message my-delimiters
  (create-segment "MSH"
      (create-field (parser/pr-delimiters my-delimiters))
      (create-field ["MYAPP"])
      (create-field ["TEST LAB"])
      (create-field ["19202830920"]))))

(def message-text (with-out-str (parser/pr-message generated-message)))

(parser/parse message-text)

I'm considering using this library for parsing and emitting HL7. It looks like Timbre is the sole dependency, but it's only really used for demonstration in com.nervestaple.hl7-parser.main. com.nervestaple.hl7-parser.parser requires Timbre, but doesn't actually use it.

Would you be willing to consider droping the Timbre dependency and perhaps replace the uses in com.nervestaple.hl7-parser.main with simple printlns? This way, Timbre wouldn't be unnecessarily brought into projects that use a different logging library.

In any case, many thanks for making this library available!