clutchski / caribou Goto Github PK

This is a feature request.

SQLITE does not support many of the ALTER statements we are used to in other RDBMS. It would be great if Caribou helped us do effortless ALTERs by doing the move-and-copy workaround for us. It could batch the alters together so that only a single move-and-copy would need to be executed.

I understand that I can do this today by implementing a migration that does this myself, but there may be room for Caribou to provide helper functions to make such a task less error prone / easier / more efficient, especially to those less familiar with this pattern.

I also understand if this is outside the intended scope of caribou, as it presents less "simple" and more "advanced/smart" feature beyond just the migration.

For an example of what I mean, you can check SQLAlchemy's Alembic project which implements this specifically for SQLite databases and is MIT licensed.

I'm trying to build my python app with Pyinstaller but I can't figure out how to make caribou work in the built version of the app. Caribou works fine when running the app using python app.py since the migration directories are preserved. In the build version, all files are build into binaries, all in the same directory ... and that leads to caribou failing with

caribou.Error: /tmp/_MEI7FKrIm/app/migrations/main is not a directory.

I'm building my app in pyinstaller's single file mode.

Do you guys plan to support sqlcipher support?

to create & run migrations

for example,

with execute(self.conn, sql, [VERSION_TABLE]) as cursor:
    return bool(cursor.fetchall())

is the same as:

with contextlib.closing(self.conn.execute(sql, [VERSION_TABLE]) as cursor:
      return bool(cursor.fetchall())

Windows doesn't respect the #! line in CLI on the script folder.

I suggest to make the CLI a module and then invoke with

python -m caribou create my_migration

Such that it is consistent across platform.

Will you take a PR for it?

thinking about adding support for other databases.

some thoughts:

• keep migrations from depending on caribou, for simplicity's sake
• pass in the cx string into migration methods, then people are free to do whatever they want with it ... use different db api adapters, sql alchemy, storm, use DDL transactions, etc.

• if an unexpected error is thrown (e.g. migration syntax error) print the traceback
• otherwise, print just the error string (e.g. "migration 1234 doesn't exist")

• examples
• basic usage
• installation